Attachment 106117 Details for Bug 57242 – silences the one-level warning by properly reducing the number of levels

[patch] silences the one-level warning by properly reducing the number of levels

0001-When-overriding-a-key-also-adjust-its-number-of-leve.patch (text/plain), 1.67 KB, created by Benno Schulenberg on 2014-09-11 09:45:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Benno Schulenberg

Created: 2014-09-11 09:45:12 UTC

Size: 1.67 KB

patch

obsolete

>From e7e28526812b9d5230001cc7cf4dbb16b16d7952 Mon Sep 17 00:00:00 2001
>From: Benno Schulenberg <bensberg@justemail.net>
>Date: Sat, 21 Sep 2013 10:32:54 +0200
>Subject: [PATCH] When overriding a key, also adjust its number of levels (#57242).
>
>This gets rid of the age-old warning of the right Alt key being
>ONE_LEVEL but having two symbols assigned.  Reducing the number
>of levels to that of the later definition takes away the cause
>of the warning.
>
>Fixes bug #57242 <http://bugs.freedesktop.org/show_bug.cgi?id=57242>.
>
>Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
>Reviewed-by: Ran Benita <ran234@gmail.com>
>---
> symbols.c |   14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
>
>diff --git a/symbols.c b/symbols.c
>index d43ba9f..d192633 100644
>--- a/symbols.c
>+++ b/symbols.c
>@@ -339,18 +339,18 @@ MergeKeyGroups(SymbolsInfo * info,
>     clobber = (from->defs.merge != MergeAugment);
>     report = (warningLevel > 9) ||
>         ((into->defs.fileID == from->defs.fileID) && (warningLevel > 0));
>-    if (into->numLevels[group] >= from->numLevels[group])
>-    {
>-        resultSyms = into->syms[group];
>-        resultActs = into->acts[group];
>-        resultWidth = into->numLevels[group];
>-    }
>-    else
>+    if ((from->numLevels[group] > into->numLevels[group]) || clobber)
>     {
>         resultSyms = from->syms[group];
>         resultActs = from->acts[group];
>         resultWidth = from->numLevels[group];
>     }
>+    else
>+    {
>+        resultSyms = into->syms[group];
>+        resultActs = into->acts[group];
>+        resultWidth = into->numLevels[group];
>+    }
>     if (resultSyms == NULL)
>     {
>         resultSyms = uTypedCalloc(resultWidth, KeySym);
>-- 
>1.7.0.4
>

Actions: View | Splinter Review

Attachments on bug 57242: 86226 | 86805 | 87136 | 87137 | 106117 | 106155 | 125761

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.