Attachment 108997 Details for Bug 83207 – Use Vmask for 3DSTATE_PS

[patch] Use Vmask for 3DSTATE_PS

0001-sna-Use-VMask-in-3DSTATE_PS.patch (text/plain), 1.25 KB, created by Rodrigo Vivi on 2014-11-05 23:49:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Rodrigo Vivi

Created: 2014-11-05 23:49:40 UTC

Size: 1.25 KB

patch

obsolete

>From 243b7aa43dd8ed7ab8f41b3dfedc34a785879a65 Mon Sep 17 00:00:00 2001
>From: Rodrigo Vivi <rodrigo.vivi@intel.com>
>Date: Wed, 5 Nov 2014 15:37:28 -0800
>Subject: [PATCH] sna: Use VMask in 3DSTATE_PS
>
>Using dispatch mask cause hangs waiting PS Done on some cases like bug #83207,
>with larger screen or when scaling it.
>
>Also mesa uses VMask instead of Dmask for 3DSTATE_PS because in some cases
>they were getting incorrect derivatives for subspans.
>
>Reference: https://bugs.freedesktop.org/show_bug.cgi?id=83207
>Cc: Timo Aaltonen <tjaalton@ubuntu.com>
>Cc: Gary Wang <gary.c.wang@intel.com>
>Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>---
> src/sna/gen8_render.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/sna/gen8_render.c b/src/sna/gen8_render.c
>index d375753..ac22808 100644
>--- a/src/sna/gen8_render.c
>+++ b/src/sna/gen8_render.c
>@@ -954,7 +954,7 @@ gen8_emit_wm(struct sna *sna, int kernel)
> 	OUT_BATCH(GEN8_3DSTATE_PS | (12 - 2));
> 	OUT_BATCH64(kernels[0] ?: kernels[1] ?: kernels[2]);
> 	OUT_BATCH(1 << PS_SAMPLER_COUNT_SHIFT |
>-		  //PS_VECTOR_MASK_ENABLE |
>+		  PS_VECTOR_MASK_ENABLE |
> 		  wm_kernels[kernel].num_surfaces << PS_BINDING_TABLE_ENTRY_COUNT_SHIFT);
> 	OUT_BATCH64(0); /* scratch address */
> 	OUT_BATCH(PS_MAX_THREADS |
>-- 
>1.9.3
>

Actions: View | Splinter Review

Attachments on bug 83207: 106758 | 106759 | 107170 | 107215 | 108334 | 108553 | 108554 | 108997 | 109004

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.