Attachment 109673 Details for Bug 86438 – fix

fix

0001-libsystemd-network-fix-writing-of-routes-in-dhcp-lea.patch (text/plain), 1.29 KB, created by Dan Winship on 2014-11-18 14:09:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dan Winship

Created: 2014-11-18 14:09:11 UTC

Size: 1.29 KB

patch

obsolete

>From 5a2eecebc43f947988edc59f0f9fe379e32373a7 Mon Sep 17 00:00:00 2001
>From: Dan Winship <danw@redhat.com>
>Date: Tue, 18 Nov 2014 08:59:42 -0500
>Subject: [PATCH] libsystemd-network: fix writing of routes in dhcp lease file
>
>inet_ntoa() uses a static buffer, so you can't call it twice in the
>same fprintf() call.
>---
> src/libsystemd-network/network-internal.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
>diff --git a/src/libsystemd-network/network-internal.c b/src/libsystemd-network/network-internal.c
>index 6f16050..f6a41f4 100644
>--- a/src/libsystemd-network/network-internal.c
>+++ b/src/libsystemd-network/network-internal.c
>@@ -392,10 +392,12 @@ void serialize_dhcp_routes(FILE *f, const char *key, struct sd_dhcp_route *route
> 
>         fprintf(f, "%s=", key);
> 
>-        for (i = 0; i < size; i++)
>-                fprintf(f, "%s/%" PRIu8 ",%s%s", inet_ntoa(routes[i].dst_addr),
>-                        routes[i].dst_prefixlen, inet_ntoa(routes[i].gw_addr),
>+        for (i = 0; i < size; i++) {
>+                fprintf(f, "%s/%" PRIu8, inet_ntoa(routes[i].dst_addr),
>+                        routes[i].dst_prefixlen);
>+                fprintf(f, ",%s%s", inet_ntoa(routes[i].gw_addr),
>                         (i < (size - 1)) ? " ": "");
>+        }
> 
>         fputs("\n", f);
> }
>-- 
>1.9.3
>

Actions: View

Attachments on bug 86438: 109673

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.