Attachment 109798 Details for Bug 85829 – lib: fix igt_reset_connectors

[patch] lib: fix igt_reset_connectors

0001-lib-fix-igt_reset_connectors.patch (text/plain), 1.09 KB, created by Thomas Wood on 2014-11-21 14:16:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Thomas Wood

Created: 2014-11-21 14:16:23 UTC

Size: 1.09 KB

patch

obsolete

>From 54356caaf4c84618885233b1681d968b8cc2a192 Mon Sep 17 00:00:00 2001
>From: Thomas Wood <thomas.wood@intel.com>
>Date: Fri, 21 Nov 2014 13:19:52 +0000
>Subject: [PATCH i-g-t] lib: fix igt_reset_connectors
>
>Use igt_debugfs_open to open the connector file, since the
>forced_connectors array now only stores the connector path relative to
>the debugfs path. Also add some extra error checking to ensure a test
>failure if the reset fails.
>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=85829
>Signed-off-by: Thomas Wood <thomas.wood@intel.com>
>---
> lib/igt_kms.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/lib/igt_kms.c b/lib/igt_kms.c
>index 5edd5ec..cba0c27 100644
>--- a/lib/igt_kms.c
>+++ b/lib/igt_kms.c
>@@ -1773,8 +1773,8 @@ void igt_reset_connectors(void)
> 	 * functions that are not safe to call in signal handlers */
> 
> 	for (tmp = forced_connectors; *tmp; tmp++) {
>-		int fd = open(*tmp, O_WRONLY | O_TRUNC);
>-		write(fd, "unspecified", 11);
>+		int fd = igt_debugfs_open(*tmp, O_WRONLY | O_TRUNC);
>+		igt_assert(write(fd, "unspecified", 11) == 11);
> 		close(fd);
> 	}
> }
>-- 
>2.1.0
>

Actions: View | Splinter Review

Attachments on bug 85829: 109183 | 109798

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.