Attachment 113592 Details for Bug 75113 – [FIX FOR 08/13] fix: initialize reserved area at the start of the query string

[patch] [FIX FOR 08/13] fix: initialize reserved area at the start of the query string

0001-fix-initialize-reserved-area-at-the-start-of-the-que.patch (text/plain), 1.12 KB, created by Tyler Hicks on 2015-02-18 03:06:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tyler Hicks

Created: 2015-02-18 03:06:13 UTC

Size: 1.12 KB

patch

obsolete

>From ae8cc76db4b2978f4afd2b6a8213fdb2c72d940a Mon Sep 17 00:00:00 2001
>From: Tyler Hicks <tyhicks@canonical.com>
>Date: Wed, 22 Oct 2014 16:36:23 -0400
>Subject: [FIX FOR 08/13] fix: initialize reserved area at the start of the query string
>
>Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
>---
> bus/apparmor.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/bus/apparmor.c b/bus/apparmor.c
>index dc90f22..6641663 100644
>--- a/bus/apparmor.c
>+++ b/bus/apparmor.c
>@@ -274,7 +274,11 @@ query_append (DBusString *query, const char *buffer)
> static dbus_bool_t
> build_common_query (DBusString *query, const char *con, const char *bustype)
> {
>-  return _dbus_string_set_length (query, AA_QUERY_CMD_LABEL_SIZE) &&
>+  /**
>+   * libapparmor's aa_query_label() function scribbles over the first
>+   * AA_QUERY_CMD_LABEL_SIZE bytes of the query string with a private value.
>+   */
>+  return _dbus_string_insert_bytes (query, 0, AA_QUERY_CMD_LABEL_SIZE, 0) &&
>          _dbus_string_append (query, con) &&
>          _dbus_string_append_byte (query, '\0') &&
>          _dbus_string_append_byte (query, AA_CLASS_DBUS) &&
>-- 
>2.1.0
>

Actions: View | Splinter Review

Attachments on bug 75113: 94222 | 94223 | 94224 | 94225 | 94226 | 94227 | 94228 | 94229 | 94231 | 94232 | 95823 | 95824 | 95825 | 95826 | 95827 | 95828 | 95829 | 95830 | 95831 | 95832 | 95833 | 95834 | 95835 | 97982 | 97983 | 97984 | 97985 | 97986 | 97987 | 97988 | 97989 | 97990 | 97991 | 97992 | 97993 | 97994 | 113585 | 113586 | 113587 | 113588 | 113589 | 113590 | 113591 | 113592 | 113593 | 113594 | 113595 | 113602 | 113603 | 113604 | 113605 | 113606 | 113607 | 113608 | 113609 | 113610 | 113625 | 113628 | 113629 | 113630 | 113631 | 113632 | 113633 | 113634 | 113635 | 113636 | 113637 | 113638 | 113639 | 113640 | 113641 | 113646

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.