Attachment 114467 Details for Bug 89673 – nicesrc: Clear the output buffer queue when shutting down and disposing

[patch] nicesrc: Clear the output buffer queue when shutting down and disposing

nicesrc-Clear-the-output-buffer-queue-when-shuttin.patch (text/plain), 1.41 KB, created by Sebastian Dröge (slomo) on 2015-03-19 09:37:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Sebastian Dröge (slomo)

Created: 2015-03-19 09:37:49 UTC

Size: 1.41 KB

patch

obsolete

>From b7bb12f874119b08504264b21863ef83b25c89dc Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= <sebastian@centricular.com>
>Date: Thu, 19 Mar 2015 09:21:23 +0100
>Subject: [PATCH] nicesrc: Clear the output buffer queue when shutting down and
> disposing
>
>https://bugs.freedesktop.org/show_bug.cgi?id=89673
>---
> gst/gstnicesrc.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
>diff --git a/gst/gstnicesrc.c b/gst/gstnicesrc.c
>index 7173cd3..de41d7f 100644
>--- a/gst/gstnicesrc.c
>+++ b/gst/gstnicesrc.c
>@@ -326,8 +326,10 @@ gst_nice_src_dispose (GObject *object)
>     g_main_context_unref (src->mainctx);
>   src->mainctx = NULL;
> 
>-  if (src->outbufs)
>+  if (src->outbufs) {
>+    g_queue_foreach (src->outbufs, (GFunc) gst_buffer_unref, NULL);
>     g_queue_free (src->outbufs);
>+  }
>   src->outbufs = NULL;
> 
>   G_OBJECT_CLASS (gst_nice_src_parent_class)->dispose (object);
>@@ -415,6 +417,10 @@ gst_nice_src_change_state (GstElement * element, GstStateChange transition)
>     case GST_STATE_CHANGE_PAUSED_TO_READY:
>       nice_agent_attach_recv (src->agent, src->stream_id, src->component_id,
>           src->mainctx, NULL, NULL);
>+      GST_OBJECT_LOCK (src);
>+      g_queue_foreach (src->outbufs, (GFunc) gst_buffer_unref, NULL);
>+      g_queue_clear (src->outbufs);
>+      GST_OBJECT_UNLOCK (src);
>       break;
>     case GST_STATE_CHANGE_READY_TO_PAUSED:
>     case GST_STATE_CHANGE_PAUSED_TO_PLAYING:
>-- 
>2.1.4

Actions: View | Splinter Review

Attachments on bug 89673: 114465 | 114466 | 114467

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.