Attachment 114826 Details for Bug 89833 – tests/kms_fbc_crc: fix fread() return value assertion

[patch] tests/kms_fbc_crc: fix fread() return value assertion

0001-tests-kms_fbc_crc-fix-fread-return-value-assertion.patch (text/plain), 1.16 KB, created by Thomas Wood on 2015-04-02 10:58:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Thomas Wood

Created: 2015-04-02 10:58:03 UTC

Size: 1.16 KB

patch

obsolete

>From 7f98f28a9293de42e6120d2dc1c1c108a6f00aa4 Mon Sep 17 00:00:00 2001
>From: Thomas Wood <thomas.wood@intel.com>
>Date: Thu, 2 Apr 2015 11:50:01 +0100
>Subject: [PATCH i-g-t] tests/kms_fbc_crc: fix fread() return value assertion
>
>Use 1 as the element size to check the number of bytes returned is
>greater than 0, rather than checking the number of elements returned.
>
>This fixes a regression from commit 47f6b13 (igt.cocci: check the
>return values of various functions).
>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89833
>Signed-off-by: Thomas Wood <thomas.wood@intel.com>
>---
> tests/kms_fbc_crc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tests/kms_fbc_crc.c b/tests/kms_fbc_crc.c
>index 10e1ca4..ccdec33 100644
>--- a/tests/kms_fbc_crc.c
>+++ b/tests/kms_fbc_crc.c
>@@ -510,7 +510,7 @@ igt_main
> 
> 		status = igt_debugfs_fopen("i915_fbc_status", "r");
> 		igt_require_f(status, "No i915_fbc_status found\n");
>-		igt_assert_eq(fread(buf, sizeof(buf), 1, status), sizeof(buf));
>+		igt_assert_lt(0, fread(buf, 1, sizeof(buf), status));
> 		fclose(status);
> 		buf[sizeof(buf) - 1] = '\0';
> 		igt_require_f(!strstr(buf, "unsupported by this chipset") &&
>-- 
>2.1.0
>

Actions: View | Splinter Review

Attachments on bug 89833: 114750 | 114826

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.