Attachment 115214 Details for Bug 90089 – Fix msvc sign-compare warning on Windows7 64bit by adding a type cast.

[patch] Fix msvc sign-compare warning on Windows7 64bit by adding a type cast.

0001-Fix-msvc-sign-compare-warning-on-Windows7-64bit-by-add.txt (text/plain), 1.54 KB, created by Ralf Habacker on 2015-04-20 10:33:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ralf Habacker

Created: 2015-04-20 10:33:54 UTC

Size: 1.54 KB

patch

obsolete

>From e8df5015611c48bfd7d971b2c3a6887c9f814262 Mon Sep 17 00:00:00 2001
>From: Ralf Habacker <ralf.habacker@freenet.de>
>Date: Mon, 20 Apr 2015 12:30:09 +0200
>Subject: [PATCH] Fix msvc sign-compare warning on Windows7 64bit by adding a
> type cast.
>
>The related warning is: C4267: 'function' : conversion from 'size_t' to 'int', possible loss of data
>---
> dbus/dbus-auth-script.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
>diff --git a/dbus/dbus-auth-script.c b/dbus/dbus-auth-script.c
>index 164743b..6e2a0a1 100644
>--- a/dbus/dbus-auth-script.c
>+++ b/dbus/dbus-auth-script.c
>@@ -526,8 +526,13 @@ _dbus_auth_script_run (const DBusString *filename)
>                     _dbus_string_free (&to_send);
>                     goto out;
>                   }
>+#ifdef _WIN64
>+                size_t c = 21323;
>+                int a = 34423423;
>+                char d = c > a;
> 
>                 _dbus_string_delete (&to_send, where, strlen ("USERID_HEX"));
>+                _dbus_string_delete (&to_send, where, (int) strlen ("USERID_HEX"));
>                 
>                 if (!_dbus_string_hex_encode (&username, 0,
> 					      &to_send, where))
>@@ -560,7 +565,7 @@ _dbus_auth_script_run (const DBusString *filename)
>                     goto out;
>                   }
> 
>-                _dbus_string_delete (&to_send, where, strlen ("USERNAME_HEX"));
>+                _dbus_string_delete (&to_send, where, (int) strlen ("USERNAME_HEX"));
>                 
>                 if (!_dbus_string_hex_encode (&username, 0,
> 					      &to_send, where))
>-- 
>1.8.4.5
>

Actions: View | Splinter Review

Attachments on bug 90089: 115179 | 115180 | 115181 | 115214 | 115215 | 115216 | 115228 | 115230 | 115407 | 115412 | 115455 | 115746 | 115748

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.