Attachment 115225 Details for Bug 90060 – drm/i915: Don't read dpcd for disconnected ports

[patch] drm/i915: Don't read dpcd for disconnected ports

0001-drm-i915-Don-t-read-dpcd-for-disconnected-ports.patch (text/plain), 1.14 KB, created by Mika Kuoppala on 2015-04-20 14:26:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mika Kuoppala

Created: 2015-04-20 14:26:48 UTC

Size: 1.14 KB

patch

obsolete

>From 87becf7541d237ae7b334635eb4441bee486ccba Mon Sep 17 00:00:00 2001
>From: Mika Kuoppala <mika.kuoppala@intel.com>
>Date: Mon, 20 Apr 2015 19:12:34 +0300
>Subject: [PATCH] drm/i915: Don't read dpcd for disconnected ports
>
>Reading from disconnected ports will spit out timeout error
>on the dmesg. Skip the attempted read if the port is not
>connected and avoid confusing users/testcases about
>expected timeouts.
>
>Cc: Jani Nikula <jani.nikula@intel.com>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90060
>Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
>---
> drivers/gpu/drm/i915/i915_debugfs.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
>index 9c2b9e4..fbc1f39 100644
>--- a/drivers/gpu/drm/i915/i915_debugfs.c
>+++ b/drivers/gpu/drm/i915/i915_debugfs.c
>@@ -4938,6 +4938,9 @@ static int i915_dpcd_show(struct seq_file *m, void *data)
> 		    connector->connector_type != DRM_MODE_CONNECTOR_eDP)
> 			continue;
> 
>+		if (connector->status != connector_status_connected)
>+			continue;
>+
> 		/* low tech for now */
> 		if (WARN_ON(size > sizeof(buf)))
> 			continue;
>-- 
>1.9.1
>

Actions: View | Splinter Review

Attachments on bug 90060: 115140 | 115225

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.