Attachment 115452 Details for Bug 90190 – drm/i915: Arm cmd parser with aliasng ppgtt only

[patch] drm/i915: Arm cmd parser with aliasng ppgtt only

0001-drm-i915-Arm-cmd-parser-with-aliasng-ppgtt-only.patch (text/plain), 1.20 KB, created by Mika Kuoppala on 2015-04-29 14:55:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mika Kuoppala

Created: 2015-04-29 14:55:47 UTC

Size: 1.20 KB

patch

obsolete

>From 4db0993d40e2f51d89c5c9ab2d19cc1b249719eb Mon Sep 17 00:00:00 2001
>From: Daniel Vetter <daniel.vetter@ffwll.ch>
>Date: Tue, 14 Apr 2015 17:35:22 +0200
>Subject: [PATCH 1/3] drm/i915: Arm cmd parser with aliasng ppgtt only
>
>With the binding regression from the original full ppgtt patches
>fixed we can throw the switch. Yay!
>
>Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
>---
> drivers/gpu/drm/i915/i915_gem_execbuffer.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
>index cfdc8c6..d2e21c5 100644
>--- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
>+++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
>@@ -1558,12 +1558,8 @@ i915_gem_do_execbuffer(struct drm_device *dev, void *data,
> 		 * dispatch_execbuffer implementations. We specifically
> 		 * don't want that set when the command parser is
> 		 * enabled.
>-		 *
>-		 * FIXME: with aliasing ppgtt, buffers that should only
>-		 * be in ggtt still end up in the aliasing ppgtt. remove
>-		 * this check when that is fixed.
> 		 */
>-		if (USES_FULL_PPGTT(dev))
>+		if (USES_PPGTT(dev))
> 			dispatch_flags |= I915_DISPATCH_SECURE;
> 
> 		exec_start = 0;
>-- 
>1.9.1
>

Actions: View | Splinter Review

Attachments on bug 90190: 115363 | 115364 | 115452 | 115453

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.