Attachment 116725 Details for Bug 73038 – Copy source and mask to the recording surface

[patch] Copy source and mask to the recording surface

0001-cairo-recording-surface-Fix-loss-of-alpha-when-clipp.patch (text/plain), 1.22 KB, created by Bryce Harrington on 2015-06-26 02:02:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bryce Harrington

Created: 2015-06-26 02:02:16 UTC

Size: 1.22 KB

patch

obsolete

>From 1bcce4362927952b25cb916f862dde6fd35f8125 Mon Sep 17 00:00:00 2001
>From: Bryce Harrington <bryce@osg.samsung.com>
>Date: Thu, 25 Jun 2015 18:54:23 -0700
>Subject: [PATCH] cairo-recording-surface: Fix loss of alpha when clipping
>
>Commit 8020e0bc introduced a regression due to a typo when copying a
>mask for a cairo recording surface.  It should copy the source and mask
>members from the command source to the recording surface, but instead it
>copies the source twice.
>
>Fix suggested by Massimo.
>
>Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=73038
>Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=73901
>Signed-off-by: Bryce Harrington <bryce@osg.samsung.com>
>---
> src/cairo-recording-surface.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/cairo-recording-surface.c b/src/cairo-recording-surface.c
>index ce29b93..78e7cfa 100644
>--- a/src/cairo-recording-surface.c
>+++ b/src/cairo-recording-surface.c
>@@ -1165,7 +1165,7 @@ _cairo_recording_surface_copy__mask (cairo_recording_surface_t *surface,
> 	goto err_command;
> 
>     status = _cairo_pattern_init_copy (&command->mask.base,
>-				       &src->mask.source.base);
>+				       &src->mask.mask.base);
>     if (unlikely (status))
> 	goto err_source;
> 
>-- 
>1.9.1
>

Actions: View | Splinter Review

Attachments on bug 73038: 116725

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.