Attachment 119072 Details for Bug 92597 – Find correct glyph or return 0

[patch] Find correct glyph or return 0

0001-Find-correct-glyph-or-return-0.patch (text/plain), 1.31 KB, created by Marek Kasik on 2015-10-22 14:34:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marek Kasik

Created: 2015-10-22 14:34:37 UTC

Size: 1.31 KB

patch

obsolete

>From eb531134b4cffd8af747eb8a33cd6c3f743c607d Mon Sep 17 00:00:00 2001
>From: Marek Kasik <mkasik@redhat.com>
>Date: Thu, 22 Oct 2015 16:11:45 +0200
>Subject: [PATCH] forms: Find correct glyph or return 0
>
>Function CharCodeToUnicode::mapToCharCode() could return
>wrong character code for given unicode character because
>of wrongly placed continue statement.
>---
> poppler/CharCodeToUnicode.cc | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
>diff --git a/poppler/CharCodeToUnicode.cc b/poppler/CharCodeToUnicode.cc
>index 5576a4a..6d77158 100644
>--- a/poppler/CharCodeToUnicode.cc
>+++ b/poppler/CharCodeToUnicode.cc
>@@ -648,17 +648,22 @@ int CharCodeToUnicode::mapToCharCode(Unicode* u, CharCode *c, int usize) {
>     *c = 'x';
>   } else {
>     int i, j;
>+    GBool cont;
>     //for each entry in the sMap
>     for (i=0; i<sMapLen; i++) {
>       //if the entry's unicode length isn't the same are usize, the strings 
>       // are obviously differents
>+      cont = gFalse;
>       if (sMap[i].len != usize) continue;
>       //compare the string char by char
>       for (j=0; j<sMap[i].len; j++) {
>         if (sMap[i].u[j] != u[j]) {
>-          continue;
>+          cont = gTrue;
>+          break;
>         }
>       }
>+      if (cont)
>+        continue;
> 
>       //we have the same strings
>       if (j==sMap[i].len) { 
>-- 
>2.4.3
>

Actions: View | Splinter Review

Attachments on bug 92597: 119072 | 119073 | 119132

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.