Attachment 121395 Details for Bug 93903 – Routing change patch

[patch] Routing change patch

0001-switch-on-port-available-Switch-from-HDMI-to-analog-.patch (text/plain), 2.01 KB, created by David Henningsson on 2016-01-29 19:32:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Henningsson

Created: 2016-01-29 19:32:18 UTC

Size: 2.01 KB

patch

obsolete

>From b1cd6767a2614f9098ed9d558e62cdb733b2e300 Mon Sep 17 00:00:00 2001
>From: David Henningsson <david.henningsson@canonical.com>
>Date: Fri, 29 Jan 2016 20:27:18 +0100
>Subject: [PATCH] switch-on-port-available: Switch from HDMI to analog; but not
> the other way around
>
>If you have headphones plugged in and plug in HDMI; you want sound
>to stay on headphones.
>If you have HDMI plugged in and you plug in headphones; you want sound
>to switch to headphones.
>
>Hence we need to take priority into account as well when determining
>whether to switch to a new profile or not.
>
>BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=93903
>Signed-off-by: David Henningsson <david.henningsson@canonical.com>
>---
> src/modules/module-switch-on-port-available.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/src/modules/module-switch-on-port-available.c b/src/modules/module-switch-on-port-available.c
>index 5dd9786..6f4c895 100644
>--- a/src/modules/module-switch-on-port-available.c
>+++ b/src/modules/module-switch-on-port-available.c
>@@ -29,7 +29,7 @@
> 
> #include "module-switch-on-port-available-symdef.h"
> 
>-static bool profile_good_for_output(pa_card_profile *profile) {
>+static bool profile_good_for_output(pa_card_profile *profile, unsigned prio) {
>     pa_sink *sink;
>     uint32_t idx;
> 
>@@ -49,7 +49,7 @@ static bool profile_good_for_output(pa_card_profile *profile) {
>         if (!sink->active_port)
>             continue;
> 
>-        if (sink->active_port->available != PA_AVAILABLE_NO)
>+        if ((sink->active_port->available != PA_AVAILABLE_NO) && (sink->active_port->priority >= prio))
>             return false;
>     }
> 
>@@ -88,7 +88,7 @@ static int try_to_switch_profile(pa_device_port *port) {
>         switch (port->direction) {
>             case PA_DIRECTION_OUTPUT:
>                 name = profile->output_name;
>-                good = profile_good_for_output(profile);
>+                good = profile_good_for_output(profile, port->priority);
>                 break;
> 
>             case PA_DIRECTION_INPUT:
>-- 
>1.9.1
>

Actions: View | Splinter Review

Attachments on bug 93903: 121383 | 121389 | 121395 | 128797 | 128999 | 129175 | 129184 | 129226 | 129265 | 129322 | 131569

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.