Attachment 122609 Details for Bug 94736 – Fix patch

[patch] Fix patch

0001-ALSA-hda-Clear-the-leftover-component-assignment-at-.patch (text/plain), 1.15 KB, created by Takashi Iwai on 2016-03-29 10:34:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Takashi Iwai

Created: 2016-03-29 10:34:03 UTC

Size: 1.15 KB

patch

obsolete

>From faafd03d23c913633d2ef7e6ffebdce01b164409 Mon Sep 17 00:00:00 2001
>From: Takashi Iwai <tiwai@suse.de>
>Date: Tue, 29 Mar 2016 12:29:24 +0200
>Subject: [PATCH] ALSA: hda - Clear the leftover component assignment at
> snd_hdac_i915_exit()
>
>The commit [d745f5e7b8b2: ALSA: hda - Add the pin / port mapping on
>Intel ILK and VLV] introduced a WARN_ON() to check the pointer for
>avoiding the double initializations.  But hdac_acomp pointer wasn't
>cleared at snd_hdac_i915_exit(), thus after reloading the HD-audio
>driver, it may result in the false positive warning.  This patch makes
>sure to clear the leftover pointer at exit.
>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94736
>Reported-by: Daniela Doras-prodan <daniela.doras-prodan@intel.com>
>Signed-off-by: Takashi Iwai <tiwai@suse.de>
>---
> sound/hda/hdac_i915.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/sound/hda/hdac_i915.c b/sound/hda/hdac_i915.c
>index 750a4ea49fa9..ae0f305a7e41 100644
>--- a/sound/hda/hdac_i915.c
>+++ b/sound/hda/hdac_i915.c
>@@ -372,6 +372,7 @@ int snd_hdac_i915_exit(struct hdac_bus *bus)
> 
> 	kfree(acomp);
> 	bus->audio_component = NULL;
>+	hdac_acomp = NULL;
> 
> 	return 0;
> }
>-- 
>2.7.4
>

Actions: View | Splinter Review

Attachments on bug 94736: 122607 | 122608 | 122609 | 122612 | 122613 | 122618

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.