Attachment 123915 Details for Bug 95492 – add ull to all unsigned long long constants

[patch] add ull to all unsigned long long constants

ull.patch (text/plain), 5.39 KB, created by Thomas Freitag on 2016-05-19 15:04:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Thomas Freitag

Created: 2016-05-19 15:04:47 UTC

Size: 5.39 KB

patch

obsolete

>diff --git a/poppler/Decrypt.cc b/poppler/Decrypt.cc
>index d67cf4e..7cc9390 100644
>--- a/poppler/Decrypt.cc
>+++ b/poppler/Decrypt.cc
>@@ -1444,22 +1444,22 @@ static void sha256(Guchar *msg, int msgLen, Guchar *hash) {
> //------------------------------------------------------------------------
> // SHA 384 and SHA 512 use the same sequence of eighty constant 64 bit words.
> static const uint64_t K[80] = {
>-  0x428a2f98d728ae22, 0x7137449123ef65cd, 0xb5c0fbcfec4d3b2f, 0xe9b5dba58189dbbc, 0x3956c25bf348b538,
>-  0x59f111f1b605d019, 0x923f82a4af194f9b, 0xab1c5ed5da6d8118, 0xd807aa98a3030242, 0x12835b0145706fbe,
>-  0x243185be4ee4b28c, 0x550c7dc3d5ffb4e2, 0x72be5d74f27b896f, 0x80deb1fe3b1696b1, 0x9bdc06a725c71235,
>-  0xc19bf174cf692694, 0xe49b69c19ef14ad2, 0xefbe4786384f25e3, 0x0fc19dc68b8cd5b5, 0x240ca1cc77ac9c65,
>-  0x2de92c6f592b0275, 0x4a7484aa6ea6e483, 0x5cb0a9dcbd41fbd4, 0x76f988da831153b5, 0x983e5152ee66dfab,
>-  0xa831c66d2db43210, 0xb00327c898fb213f, 0xbf597fc7beef0ee4, 0xc6e00bf33da88fc2, 0xd5a79147930aa725,
>-  0x06ca6351e003826f, 0x142929670a0e6e70, 0x27b70a8546d22ffc, 0x2e1b21385c26c926, 0x4d2c6dfc5ac42aed,
>-  0x53380d139d95b3df, 0x650a73548baf63de, 0x766a0abb3c77b2a8, 0x81c2c92e47edaee6, 0x92722c851482353b,
>-  0xa2bfe8a14cf10364, 0xa81a664bbc423001, 0xc24b8b70d0f89791, 0xc76c51a30654be30, 0xd192e819d6ef5218,
>-  0xd69906245565a910, 0xf40e35855771202a, 0x106aa07032bbd1b8, 0x19a4c116b8d2d0c8, 0x1e376c085141ab53,
>-  0x2748774cdf8eeb99, 0x34b0bcb5e19b48a8, 0x391c0cb3c5c95a63, 0x4ed8aa4ae3418acb, 0x5b9cca4f7763e373,
>-  0x682e6ff3d6b2b8a3, 0x748f82ee5defb2fc, 0x78a5636f43172f60, 0x84c87814a1f0ab72, 0x8cc702081a6439ec,
>-  0x90befffa23631e28, 0xa4506cebde82bde9, 0xbef9a3f7b2c67915, 0xc67178f2e372532b, 0xca273eceea26619c,
>-  0xd186b8c721c0c207, 0xeada7dd6cde0eb1e, 0xf57d4f7fee6ed178, 0x06f067aa72176fba, 0x0a637dc5a2c898a6,
>-  0x113f9804bef90dae, 0x1b710b35131c471b, 0x28db77f523047d84, 0x32caab7b40c72493, 0x3c9ebe0a15c9bebc,
>-  0x431d67c49c100d4c, 0x4cc5d4becb3e42b6, 0x597f299cfc657e2a, 0x5fcb6fab3ad6faec, 0x6c44198c4a475817
>+  0x428a2f98d728ae22ull, 0x7137449123ef65cdull, 0xb5c0fbcfec4d3b2full, 0xe9b5dba58189dbbcull, 0x3956c25bf348b538ull,
>+  0x59f111f1b605d019ull, 0x923f82a4af194f9bull, 0xab1c5ed5da6d8118ull, 0xd807aa98a3030242ull, 0x12835b0145706fbeull,
>+  0x243185be4ee4b28cull, 0x550c7dc3d5ffb4e2ull, 0x72be5d74f27b896full, 0x80deb1fe3b1696b1ull, 0x9bdc06a725c71235ull,
>+  0xc19bf174cf692694ull, 0xe49b69c19ef14ad2ull, 0xefbe4786384f25e3ull, 0x0fc19dc68b8cd5b5ull, 0x240ca1cc77ac9c65ull,
>+  0x2de92c6f592b0275ull, 0x4a7484aa6ea6e483ull, 0x5cb0a9dcbd41fbd4ull, 0x76f988da831153b5ull, 0x983e5152ee66dfabull,
>+  0xa831c66d2db43210ull, 0xb00327c898fb213full, 0xbf597fc7beef0ee4ull, 0xc6e00bf33da88fc2ull, 0xd5a79147930aa725ull,
>+  0x06ca6351e003826full, 0x142929670a0e6e70ull, 0x27b70a8546d22ffcull, 0x2e1b21385c26c926ull, 0x4d2c6dfc5ac42aedull,
>+  0x53380d139d95b3dfull, 0x650a73548baf63deull, 0x766a0abb3c77b2a8ull, 0x81c2c92e47edaee6ull, 0x92722c851482353bull,
>+  0xa2bfe8a14cf10364ull, 0xa81a664bbc423001ull, 0xc24b8b70d0f89791ull, 0xc76c51a30654be30ull, 0xd192e819d6ef5218ull,
>+  0xd69906245565a910ull, 0xf40e35855771202aull, 0x106aa07032bbd1b8ull, 0x19a4c116b8d2d0c8ull, 0x1e376c085141ab53ull,
>+  0x2748774cdf8eeb99ull, 0x34b0bcb5e19b48a8ull, 0x391c0cb3c5c95a63ull, 0x4ed8aa4ae3418acbull, 0x5b9cca4f7763e373ull,
>+  0x682e6ff3d6b2b8a3ull, 0x748f82ee5defb2fcull, 0x78a5636f43172f60ull, 0x84c87814a1f0ab72ull, 0x8cc702081a6439ecull,
>+  0x90befffa23631e28ull, 0xa4506cebde82bde9ull, 0xbef9a3f7b2c67915ull, 0xc67178f2e372532bull, 0xca273eceea26619cull,
>+  0xd186b8c721c0c207ull, 0xeada7dd6cde0eb1eull, 0xf57d4f7fee6ed178ull, 0x06f067aa72176fbaull, 0x0a637dc5a2c898a6ull,
>+  0x113f9804bef90daeull, 0x1b710b35131c471bull, 0x28db77f523047d84ull, 0x32caab7b40c72493ull, 0x3c9ebe0a15c9bebcull,
>+  0x431d67c49c100d4cull, 0x4cc5d4becb3e42b6ull, 0x597f299cfc657e2aull, 0x5fcb6fab3ad6faecull, 0x6c44198c4a475817ull
> };
> 
> static inline uint64_t rotr(uint64_t x, uint64_t n) {
>@@ -1548,14 +1548,14 @@ static void sha512(Guchar *msg, int msgLen, Guchar *hash) {
>   uint64_t H[8];
>   int blkLen = 0, i;
>  // setting the initial hash value.
>-  H[0] = 0x6a09e667f3bcc908;
>-  H[1] = 0xbb67ae8584caa73b;
>-  H[2] = 0x3c6ef372fe94f82b;
>-  H[3] = 0xa54ff53a5f1d36f1;
>-  H[4] = 0x510e527fade682d1;
>-  H[5] = 0x9b05688c2b3e6c1f;
>-  H[6] = 0x1f83d9abfb41bd6b;
>-  H[7] = 0x5be0cd19137e2179;
>+  H[0] = 0x6a09e667f3bcc908ull;
>+  H[1] = 0xbb67ae8584caa73bull;
>+  H[2] = 0x3c6ef372fe94f82bull;
>+  H[3] = 0xa54ff53a5f1d36f1ull;
>+  H[4] = 0x510e527fade682d1ull;
>+  H[5] = 0x9b05688c2b3e6c1full;
>+  H[6] = 0x1f83d9abfb41bd6bull;
>+  H[7] = 0x5be0cd19137e2179ull;
> 
>   for (i = 0; i + 128 <= msgLen; i += 128) {
>     sha512HashBlock(msg + i, H);
>@@ -1620,14 +1620,14 @@ static void sha384(Guchar *msg, int msgLen, Guchar *hash) {
>   uint64_t H[8];
>   int blkLen, i;
> //setting initial hash values
>-  H[0] = 0xcbbb9d5dc1059ed8;
>-  H[1] = 0x629a292a367cd507;
>-  H[2] = 0x9159015a3070dd17;
>-  H[3] = 0x152fecd8f70e5939;
>-  H[4] = 0x67332667ffc00b31;
>-  H[5] = 0x8eb44a8768581511;
>-  H[6] = 0xdb0c2e0d64f98fa7;
>-  H[7] = 0x47b5481dbefa4fa4;
>+  H[0] = 0xcbbb9d5dc1059ed8ull;
>+  H[1] = 0x629a292a367cd507ull;
>+  H[2] = 0x9159015a3070dd17ull;
>+  H[3] = 0x152fecd8f70e5939ull;
>+  H[4] = 0x67332667ffc00b31ull;
>+  H[5] = 0x8eb44a8768581511ull;
>+  H[6] = 0xdb0c2e0d64f98fa7ull;
>+  H[7] = 0x47b5481dbefa4fa4ull;
> //SHA 384 will use the same sha512HashBlock function.
>   blkLen = 0;
>   for (i = 0; i + 128 <= msgLen; i += 128) {

Actions: View | Splinter Review

Attachments on bug 95492: 123915

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.