Attachment 124152 Details for Bug 96264 – Patch to fix memory leaks

[patch] Patch to fix memory leaks

0001-Fix-a-couple-of-minor-memory-leaks.patch (text/plain), 1.23 KB, created by Erik on 2016-05-29 02:47:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Erik

Created: 2016-05-29 02:47:40 UTC

Size: 1.23 KB

patch

obsolete

>From 737eac6b05b5433a36ca95efc8808838d14369a5 Mon Sep 17 00:00:00 2001
>From: Erik de Castro Lopo <erikd@mega-nerd.com>
>Date: Sat, 28 May 2016 17:44:10 +1100
>Subject: [PATCH] Fix a couple of minor memory leaks
>
>These fixes are needed for the test suite to pass when compiled
>with Address Sanitizer.
>---
> src/fccache.c       | 2 ++
> test/test-bz89617.c | 2 ++
> 2 files changed, 4 insertions(+)
>
>diff --git a/src/fccache.c b/src/fccache.c
>index 3344a09..71e8f03 100644
>--- a/src/fccache.c
>+++ b/src/fccache.c
>@@ -1173,6 +1173,7 @@ FcDirCacheLock (const FcChar8 *dir,
> 	if (!cache_hashed)
> 	    break;
> 	fd = FcOpen ((const char *)cache_hashed, O_RDWR);
>+	FcStrFree (cache_hashed);
> 	/* No caches in that directory. simply retry with another one */
> 	if (fd != -1)
> 	{
>@@ -1196,6 +1197,7 @@ FcDirCacheLock (const FcChar8 *dir,
>     FcStrListDone (list);
>     return fd;
> bail:
>+    FcStrListDone (list);
>     if (fd != -1)
> 	close (fd);
>     return -1;
>diff --git a/test/test-bz89617.c b/test/test-bz89617.c
>index 35df885..f8139a6 100644
>--- a/test/test-bz89617.c
>+++ b/test/test-bz89617.c
>@@ -34,5 +34,7 @@ main (void)
> 	FcConfigAppFontAddFile (config, (const FcChar8 *)"/dev/null"))
> 	return 1;
> 
>+    FcConfigDestroy (config);
>+
>     return 0;
> }
>-- 
>2.8.1
>

Actions: View | Splinter Review

Attachments on bug 96264: 124152

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.