Attachment 124176 Details for Bug 96255 – [PATCH] drm/i915: Extract physical display dimensions from VBT

[patch] [PATCH] drm/i915: Extract physical display dimensions from VBT

0001-drm-i915-Extract-physical-display-dimensions-from-VB.patch (text/plain), 2.94 KB, created by Ville Syrjala on 2016-05-30 13:31:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ville Syrjala

Created: 2016-05-30 13:31:26 UTC

Size: 2.94 KB

patch

obsolete

>From 3c1f2e63bb3c0da9e92675fb52f70b9b38304123 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= <ville.syrjala@linux.intel.com>
>Date: Mon, 30 May 2016 16:20:48 +0300
>Subject: [PATCH] drm/i915: Extract physical display dimensions from VBT
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>The VBT has these mysterious H/V image sizes as part of the display
>timings. Looking at some dumps those appear to be the physical
>dimensions in mm. Which makes sense since the timing descriptor matches
>the format used by EDID detailed timing descriptor, which defines these
>as "H/V Addressable Video Image Size in mm".
>
>So let's use that information from the panel fixed mode to get the
>physical dimensions for DSI displays. And with that we can fill out
>the display_info so that userspace can get at it via GetConnector.
>
>TODO: Should do the same for other output types as well probably.
>
>Cc: Stephen Just <stephenjust@gmail.com>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96255
>Signed-off-by: Ville SyrjÃ¤lÃ¤ <ville.syrjala@linux.intel.com>
>---
> drivers/gpu/drm/i915/intel_bios.c     | 5 +++++
> drivers/gpu/drm/i915/intel_dsi.c      | 3 +++
> drivers/gpu/drm/i915/intel_vbt_defs.h | 7 ++++---
> 3 files changed, 12 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
>index 624e755e451f..cb5024771b30 100644
>--- a/drivers/gpu/drm/i915/intel_bios.c
>+++ b/drivers/gpu/drm/i915/intel_bios.c
>@@ -139,6 +139,11 @@ fill_detail_timing_data(struct drm_display_mode *panel_fixed_mode,
> 	else
> 		panel_fixed_mode->flags |= DRM_MODE_FLAG_NVSYNC;
> 
>+	panel_fixed_mode->width_mm = (dvo_timing->himage_hi << 4) +
>+		dvo_timing->himage_lo;
>+	panel_fixed_mode->height_mm = (dvo_timing->vimage_hi << 4) +
>+		dvo_timing->vimage_lo;
>+
> 	/* Some VBTs have bogus h/vtotal values */
> 	if (panel_fixed_mode->hsync_end > panel_fixed_mode->htotal)
> 		panel_fixed_mode->htotal = panel_fixed_mode->hsync_end + 1;
>diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
>index 4009618a5b34..d76943683a35 100644
>--- a/drivers/gpu/drm/i915/intel_dsi.c
>+++ b/drivers/gpu/drm/i915/intel_dsi.c
>@@ -1578,6 +1578,9 @@ void intel_dsi_init(struct drm_device *dev)
> 		goto err;
> 	}
> 
>+	connector->display_info.width_mm = fixed_mode->width_mm;
>+	connector->display_info.height_mm = fixed_mode->height_mm;
>+
> 	intel_panel_init(&intel_connector->panel, fixed_mode, NULL);
> 
> 	intel_dsi_add_properties(intel_connector);
>diff --git a/drivers/gpu/drm/i915/intel_vbt_defs.h b/drivers/gpu/drm/i915/intel_vbt_defs.h
>index 4f9799f025a9..68db9621f1f0 100644
>--- a/drivers/gpu/drm/i915/intel_vbt_defs.h
>+++ b/drivers/gpu/drm/i915/intel_vbt_defs.h
>@@ -403,9 +403,10 @@ struct lvds_dvo_timing {
> 	u8 vsync_off:4;
> 	u8 rsvd0:6;
> 	u8 hsync_off_hi:2;
>-	u8 h_image;
>-	u8 v_image;
>-	u8 max_hv;
>+	u8 himage_lo;
>+	u8 vimage_lo;
>+	u8 vimage_hi:4;
>+	u8 himage_hi:4;
> 	u8 h_border;
> 	u8 v_border;
> 	u8 rsvd1:3;
>-- 
>2.7.4
>

Actions: View | Splinter Review

Attachments on bug 96255: 124140 | 124141 | 124142 | 124143 | 124150 | 124176 | 124188 | 124189 | 124190 | 124201

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.