Attachment 126076 Details for Bug 97506 – [PATCH] check GooString size (only for 64-bit platforms)

[patch] [PATCH] check GooString size (only for 64-bit platforms)

0001-check-GooString-size-only-for-64-bit-platforms.patch (text/plain), 1.01 KB, created by Jakub Alba on 2016-08-27 23:06:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jakub Alba

Created: 2016-08-27 23:06:16 UTC

Size: 1.01 KB

patch

obsolete

>From 466a42cab495caeeb780834f04cf959235b0f578 Mon Sep 17 00:00:00 2001
>From: Jakub Kucharski <jakubkucharski97@gmail.com>
>Date: Sun, 28 Aug 2016 01:04:46 +0200
>Subject: [PATCH] check GooString size (only for 64-bit platforms)
>
>---
> goo/GooString.cc | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
>diff --git a/goo/GooString.cc b/goo/GooString.cc
>index e7208db..626f5fb 100644
>--- a/goo/GooString.cc
>+++ b/goo/GooString.cc
>@@ -204,6 +204,14 @@ GooString::GooString() {
> #if __cplusplus >= 201103L
>   static_assert(sizeof(GooString) == GooString::STR_FINAL_SIZE, "You should check memory alignment or STR_STATIC_SIZE calculation.");
> #endif
>+
>+  fprintf(stderr, "performing offset checks\n");
>+  assert(STR_STATIC_SIZE == 20);
>+  assert(sizeof sStatic == STR_STATIC_SIZE);
>+  assert(&length == &sStatic[0] + STR_STATIC_SIZE);
>+  assert(&length + sizeof length == &s);
>+  assert(sizeof(GooString) == 32);
>+  assert(sizeof(GooString) == sizeof sStatic + sizeof length + sizeof s);
> }
> 
> GooString::GooString(const char *sA) {
>-- 
>2.9.3
>

Actions: View | Splinter Review

Attachments on bug 97506: 126067 | 126068 | 126076

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.