Attachment 126962 Details for Bug 98025 – Patch fixing issue

[patch] Patch fixing issue

0001-radeonsi-Fix-primitive-restart-when-index-changes.patch (text/plain), 1.69 KB, created by James Legg on 2016-10-03 09:59:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: James Legg

Created: 2016-10-03 09:59:48 UTC

Size: 1.69 KB

patch

obsolete

>From e6a73c5c93eed1dc3497db6b11eb6e1be1cf5c5e Mon Sep 17 00:00:00 2001
>From: James Legg <jlegg@feralinteractive.com>
>Date: Mon, 3 Oct 2016 10:32:16 +0100
>Subject: [PATCH] radeonsi: Fix primitive restart when index changes
>
>If primitive restart is enabled for two consecutive draws which use
>different primitive restart indices, then the first draw's primitive
>restart index was incorrectly used for the second draw.
>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98025
>---
> src/gallium/drivers/radeonsi/si_state_draw.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
>diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c
>index e44147f..10e8be4 100644
>--- a/src/gallium/drivers/radeonsi/si_state_draw.c
>+++ b/src/gallium/drivers/radeonsi/si_state_draw.c
>@@ -509,13 +509,13 @@ static void si_emit_draw_registers(struct si_context *sctx,
> 		radeon_set_context_reg(cs, R_028A94_VGT_MULTI_PRIM_IB_RESET_EN, info->primitive_restart);
> 		sctx->last_primitive_restart_en = info->primitive_restart;
> 
>-		if (info->primitive_restart &&
>-		    (info->restart_index != sctx->last_restart_index ||
>-		     sctx->last_restart_index == SI_RESTART_INDEX_UNKNOWN)) {
>-			radeon_set_context_reg(cs, R_02840C_VGT_MULTI_PRIM_IB_RESET_INDX,
>-					       info->restart_index);
>-			sctx->last_restart_index = info->restart_index;
>-		}
>+	}
>+	if (info->primitive_restart &&
>+	    (info->restart_index != sctx->last_restart_index ||
>+	     sctx->last_restart_index == SI_RESTART_INDEX_UNKNOWN)) {
>+		radeon_set_context_reg(cs, R_02840C_VGT_MULTI_PRIM_IB_RESET_INDX,
>+				       info->restart_index);
>+		sctx->last_restart_index = info->restart_index;
> 	}
> }
> 
>-- 
>2.8.3
>

Actions: View | Splinter Review

Attachments on bug 98025: 126961 | 126962

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.