Attachment 127220 Details for Bug 98200 – patch 2/2

[patch] patch 2/2

0002-drm-radeon-fix-modeset-tear-down-code.patch (text/plain), 1.43 KB, created by Alex Deucher on 2016-10-11 16:30:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2016-10-11 16:30:37 UTC

Size: 1.43 KB

patch

obsolete

>From cb807e5b329c447b8ca108ab112d0550fbd7d4aa Mon Sep 17 00:00:00 2001
>From: Alex Deucher <alexander.deucher@amd.com>
>Date: Tue, 11 Oct 2016 10:57:39 -0400
>Subject: [PATCH 2/2] drm/radeon: fix modeset tear down code
>
>The ordering caused problems.
>
>bug:
>https://bugs.freedesktop.org/show_bug.cgi?id=98200
>
>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>---
> drivers/gpu/drm/radeon/radeon_display.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
>diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
>index b8ab30a..cdb8cb56 100644
>--- a/drivers/gpu/drm/radeon/radeon_display.c
>+++ b/drivers/gpu/drm/radeon/radeon_display.c
>@@ -1675,20 +1675,20 @@ int radeon_modeset_init(struct radeon_device *rdev)
> 
> void radeon_modeset_fini(struct radeon_device *rdev)
> {
>-	radeon_fbdev_fini(rdev);
>-	kfree(rdev->mode_info.bios_hardcoded_edid);
>-
>-	/* free i2c buses */
>-	radeon_i2c_fini(rdev);
>-
> 	if (rdev->mode_info.mode_config_initialized) {
>-		radeon_afmt_fini(rdev);
> 		drm_kms_helper_poll_fini(rdev->ddev);
> 		radeon_hpd_fini(rdev);
> 		drm_crtc_force_disable_all(rdev->ddev);
>+		radeon_fbdev_fini(rdev);
>+		radeon_afmt_fini(rdev);
> 		drm_mode_config_cleanup(rdev->ddev);
> 		rdev->mode_info.mode_config_initialized = false;
> 	}
>+
>+	kfree(rdev->mode_info.bios_hardcoded_edid);
>+
>+	/* free i2c buses */
>+	radeon_i2c_fini(rdev);
> }
> 
> static bool is_hdtv_mode(const struct drm_display_mode *mode)
>-- 
>2.5.5
>

Actions: View | Splinter Review

Attachments on bug 98200: 127199 | 127219 | 127220

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.