Attachment 128770 Details for Bug 98330 – mesa fix

[patch] mesa fix

0001-i965-call-intel_prepare_render-always-when-reading-p.patch (text/plain), 1.93 KB, created by Tapani Pälli on 2017-01-05 12:20:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tapani Pälli

Created: 2017-01-05 12:20:15 UTC

Size: 1.93 KB

patch

obsolete

>From efc3e39dec9b27189866f4642583a572e4877243 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Tapani=20P=C3=A4lli?= <tapani.palli@intel.com>
>Date: Thu, 5 Jan 2017 13:40:35 +0200
>Subject: [PATCH] i965: call intel_prepare_render always when reading pixels
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Currently we do this only in the fallback code (when tiled memcpy
>version failed) but it needs to be done always so that we have
>correct read and write buffer in place. No regressions seen in CI.
>
>Fixes:
>	dEQP-EGL.functional.buffer_age.*
>
>Signed-off-by: Tapani PÃ¤lli <tapani.palli@intel.com>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98330
>---
> src/mesa/drivers/dri/i965/intel_pixel_read.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/src/mesa/drivers/dri/i965/intel_pixel_read.c b/src/mesa/drivers/dri/i965/intel_pixel_read.c
>index c15f891..2563897 100644
>--- a/src/mesa/drivers/dri/i965/intel_pixel_read.c
>+++ b/src/mesa/drivers/dri/i965/intel_pixel_read.c
>@@ -242,17 +242,17 @@ intelReadPixels(struct gl_context * ctx,
>       perf_debug("%s: fallback to CPU mapping in PBO case\n", __func__);
>    }
> 
>-   ok = intel_readpixels_tiled_memcpy(ctx, x, y, width, height,
>-                                      format, type, pixels, pack);
>-   if(ok)
>-      return;
>-
>-   /* glReadPixels() wont dirty the front buffer, so reset the dirty
>+   /* Reading pixels wont dirty the front buffer, so reset the dirty
>     * flag after calling intel_prepare_render(). */
>    dirty = brw->front_buffer_dirty;
>    intel_prepare_render(brw);
>    brw->front_buffer_dirty = dirty;
> 
>+   ok = intel_readpixels_tiled_memcpy(ctx, x, y, width, height,
>+                                      format, type, pixels, pack);
>+   if(ok)
>+      return;
>+
>    /* Update Mesa state before calling _mesa_readpixels().
>     * XXX this may not be needed since ReadPixels no longer uses the
>     * span code.
>-- 
>2.9.3
>

Actions: View | Splinter Review

Attachments on bug 98330: 128391 | 128709 | 128710 | 128769 | 128770

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.