Attachment 129340 Details for Bug 99488 – assert on infinite loop

[patch] assert on infinite loop

0001-AMDGPU-R600-Assert-on-infinite-loop-in-EmitClauseMar.patch (text/plain), 1.02 KB, created by Jan Vesely on 2017-02-04 22:47:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jan Vesely

Created: 2017-02-04 22:47:34 UTC

Size: 1.02 KB

patch

obsolete

>From 3aa75b5fc46aa96ffa5cda601bf2e0caf3f3f5d0 Mon Sep 17 00:00:00 2001
>From: Jan Vesely <jan.vesely@rutgers.edu>
>Date: Sat, 4 Feb 2017 17:34:56 -0500
>Subject: [PATCH 1/1] AMDGPU/R600: Assert on infinite loop in EmitClauseMarkers
>
>Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
>---
> lib/Target/AMDGPU/R600EmitClauseMarkers.cpp | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/lib/Target/AMDGPU/R600EmitClauseMarkers.cpp b/lib/Target/AMDGPU/R600EmitClauseMarkers.cpp
>index ceb5870..7bcf88b 100644
>--- a/lib/Target/AMDGPU/R600EmitClauseMarkers.cpp
>+++ b/lib/Target/AMDGPU/R600EmitClauseMarkers.cpp
>@@ -321,9 +321,11 @@ public:
>       if (I != MBB.end() && I->getOpcode() == AMDGPU::CF_ALU)
>         continue; // BB was already parsed
>       for (MachineBasicBlock::iterator E = MBB.end(); I != E;) {
>-        if (isALU(*I))
>+        if (isALU(*I)) {
>+          auto old = I;
>           I = MakeALUClause(MBB, I);
>-        else
>+          assert(old != I);
>+        } else
>           ++I;
>       }
>     }
>-- 
>2.9.3
>

Actions: View | Splinter Review

Attachments on bug 99488: 129340 | 129815 | 129933

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.