Attachment 132155 Details for Bug 101261 – [PATCH] drm/i915: Disable MSI for all pre-gen5

[patch] [PATCH] drm/i915: Disable MSI for all pre-gen5

0001-drm-i915-Disable-MSI-for-all-pre-gen5.patch (text/plain), 1.16 KB, created by Ville Syrjala on 2017-06-23 10:51:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ville Syrjala

Created: 2017-06-23 10:51:15 UTC

Size: 1.16 KB

patch

obsolete

>From f841b2a31bb439eb317a608650b6d22d885f2e6a Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= <ville.syrjala@linux.intel.com>
>Date: Fri, 23 Jun 2017 13:48:30 +0300
>Subject: [PATCH] drm/i915: Disable MSI for all pre-gen5
>
>---
> drivers/gpu/drm/i915/i915_drv.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
>index d1aa10c9cc5d..f158877ae6f7 100644
>--- a/drivers/gpu/drm/i915/i915_drv.c
>+++ b/drivers/gpu/drm/i915/i915_drv.c
>@@ -1136,10 +1136,11 @@ static int i915_driver_init_hw(struct drm_i915_private *dev_priv)
> 	 * and the registers being closely associated.
> 	 *
> 	 * According to chipset errata, on the 965GM, MSI interrupts may
>-	 * be lost or delayed, but we use them anyways to avoid
>-	 * stuck interrupts on some machines.
>+	 * be lost or delayed, and was defeatured. MSI interrupts seem to
>+	 * be lost on GM45 as well, so we'll just disable them for all
>+	 * pre-gen5 chipsets.
> 	 */
>-	if (!IS_I945G(dev_priv) && !IS_I945GM(dev_priv)) {
>+	if (INTEL_GEN(dev_priv) >= 5) {
> 		if (pci_enable_msi(pdev) < 0)
> 			DRM_DEBUG_DRIVER("can't enable MSI");
> 	}
>-- 
>2.13.0
>

Actions: View | Splinter Review

Attachments on bug 101261: 131623 | 131624 | 131625 | 131626 | 131689 | 131937 | 131938 | 132149 | 132155 | 132208

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.