Attachment 132941 Details for Bug 100907 – [PATCH] drm/i915: Revert ea0000f0 "Roll out the helper nonblock

[patch] [PATCH] drm/i915: Revert ea0000f0 "Roll out the helper nonblock

0001-drm-i915-Revert-ea0000f0-4.12 (text/plain), 2.21 KB, created by Jim Rees on 2017-07-25 00:57:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jim Rees

Created: 2017-07-25 00:57:02 UTC

Size: 2.21 KB

patch

obsolete

>From c71f87aa8d25061bc7bbf56e5e2fd71aab7232aa Mon Sep 17 00:00:00 2001
>From: Jim Rees <rees@umich.edu>
>Date: Sat, 19 Nov 2016 14:13:20 -0500
>Subject: [PATCH] drm/i915: Revert ea0000f0 "Roll out the helper nonblock
> tracking"
>
>Commit ea0000f0 has been causing multiple problems for i915 users. See for
>example:
>
>https://bugs.freedesktop.org/show_bug.cgi?id=96781
>https://bugs.freedesktop.org/show_bug.cgi?id=97529
>https://bugzilla.redhat.com/show_bug.cgi?id=1385228
>https://forums.opensuse.org/showthread.php/520969-drm-915-Resetting-chip-after-gpu-hang
>
>Those last two are not confirmed but look like the same problem.
>
>Signed-off-by: Jim Rees <rees@umich.edu>
>---
> drivers/gpu/drm/i915/intel_display.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
>index 9106ea32b048..2ec383c20980 100644
>--- a/drivers/gpu/drm/i915/intel_display.c
>+++ b/drivers/gpu/drm/i915/intel_display.c
>@@ -12804,8 +12804,6 @@ static void intel_atomic_commit_tail(struct drm_atomic_state *state)
> 	unsigned crtc_vblank_mask = 0;
> 	int i;
> 
>-	drm_atomic_helper_wait_for_dependencies(state);
>-
> 	if (intel_state->modeset)
> 		intel_display_power_get(dev_priv, POWER_DOMAIN_MODESET);
> 
>@@ -12930,8 +12928,6 @@ static void intel_atomic_commit_tail(struct drm_atomic_state *state)
> 	if (intel_state->modeset && intel_can_enable_sagv(state))
> 		intel_enable_sagv(dev_priv);
> 
>-	drm_atomic_helper_commit_hw_done(state);
>-
> 	if (intel_state->modeset)
> 		intel_display_power_put(dev_priv, POWER_DOMAIN_MODESET);
> 
>@@ -12939,8 +12935,6 @@ static void intel_atomic_commit_tail(struct drm_atomic_state *state)
> 	drm_atomic_helper_cleanup_planes(dev, state);
> 	mutex_unlock(&dev->struct_mutex);
> 
>-	drm_atomic_helper_commit_cleanup_done(state);
>-
> 	drm_atomic_state_put(state);
> 
> 	/* As one of the primary mmio accessors, KMS has a high likelihood
>@@ -13026,10 +13020,6 @@ static int intel_atomic_commit(struct drm_device *dev,
> 	struct drm_i915_private *dev_priv = to_i915(dev);
> 	int ret = 0;
> 
>-	ret = drm_atomic_helper_setup_commit(state, nonblock);
>-	if (ret)
>-		return ret;
>-
> 	drm_atomic_state_get(state);
> 	i915_sw_fence_init(&intel_state->commit_ready,
> 			   intel_atomic_commit_ready);
>-- 
>2.13.3
>

Actions: View | Splinter Review

Attachments on bug 100907: 131178 | 131179 | 131180 | 131229 | 132848 | 132941 | 132997 | 136351 | 136718

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.