Attachment 1330 Details for Bug 1889 – [FIXED_X11R68x] simple patch

[patch] [FIXED_X11R68x] simple patch

009_ati_r128_retry_idle_until_timeout.diff (text/plain), 1.29 KB, created by Daniel Stone on 2004-11-22 09:42:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Stone

Created: 2004-11-22 09:42:04 UTC

Size: 1.29 KB

patch

obsolete

>$Id: 009_ati_r128_retry_idle_until_timeout.diff 2011 2004-11-04 14:25:23Z branden $
>
>Attempt to mitigate serious DRI performance problems on Rage 128 chips by
>retrying CCE idle commands until the timeout is reached.  See Debian
>#223089, #236187, #236373, #243436.
>
>This patch by Daniel Jacobowitz.
>
>Not submitted to XFree86 upstream.
>
>--- xc/programs/Xserver/hw/xfree86/drivers/ati/r128_accel.c~	2004-06-01 12:17:33.000000000 -0500
>+++ xc/programs/Xserver/hw/xfree86/drivers/ati/r128_accel.c	2004-06-01 12:21:37.000000000 -0500
>@@ -237,17 +237,23 @@
>         i = 0;
>         do {
>             ret = drmCommandNone(info->drmFD, DRM_R128_CCE_IDLE);
>-        } while ( ret && errno == EBUSY && i++ < R128_IDLE_RETRY );
>+        } while ( ret && errno == EBUSY && i++ < (R128_IDLE_RETRY * R128_IDLE_RETRY) );
> 
> 	if (ret && ret != -EBUSY) {
> 	    xf86DrvMsg(pScrn->scrnIndex, X_ERROR,
> 		       "%s: CCE idle %d\n", __FUNCTION__, ret);
> 	}
> 
>+	if (i > R128_IDLE_RETRY) {
>+	    xf86DrvMsg(pScrn->scrnIndex, X_ERROR,
>+		       "%s: (DEBUG) CCE idle took i = %d\n", __FUNCTION__, i);
>+	}
>+
> 	if (ret == 0) return;
> 
> 	xf86DrvMsg(pScrn->scrnIndex, X_ERROR,
> 		   "Idle timed out, resetting engine...\n");
>+	R128CCE_STOP(pScrn, info);
> 	R128EngineReset(pScrn);
> 
> 	/* Always restart the engine when doing CCE 2D acceleration */

Flags:

roland.mainz: 6.8-branch+

Actions: View | Splinter Review

Attachments on bug 1889: 1330 | 5561 | 5562

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.