Attachment 133276 Details for Bug 101334 – fix MSAA rendering.

[patch] fix MSAA rendering.

0001-radv-fix-MSAA-on-SI-gpus.patch (text/plain), 1.43 KB, created by Dave Airlie on 2017-08-07 06:57:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dave Airlie

Created: 2017-08-07 06:57:28 UTC

Size: 1.43 KB

patch

obsolete

>From 3d5b2d3b3bdc9aced3e625dd25f0649340375eae Mon Sep 17 00:00:00 2001
>From: Dave Airlie <airlied@redhat.com>
>Date: Mon, 7 Aug 2017 07:39:41 +0100
>Subject: [PATCH] radv: fix MSAA on SI gpus.
>
>This ports the workaround from radeonsi, that was missing in radv.
>
>This fixes Talos rendering when MSAA is enabled on my Tahiti card.
>
>Fixes: f4e499ec7 (radv: add initial non-conformant radv vulkan driver)
>Signed-off-by: Dave Airlie <airlied@redhat.com>
>---
> src/amd/vulkan/radv_device.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
>diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
>index e5bedf3..85ba165 100644
>--- a/src/amd/vulkan/radv_device.c
>+++ b/src/amd/vulkan/radv_device.c
>@@ -3089,9 +3089,13 @@ radv_initialise_color_surface(struct radv_device *device,
> 				    format != V_028C70_COLOR_24_8) |
> 		S_028C70_NUMBER_TYPE(ntype) |
> 		S_028C70_ENDIAN(endian);
>-	if (iview->image->info.samples > 1)
>-		if (iview->image->fmask.size)
>-			cb->cb_color_info |= S_028C70_COMPRESSION(1);
>+	if ((iview->image->info.samples > 1) && iview->image->fmask.size) {
>+		cb->cb_color_info |= S_028C70_COMPRESSION(1);
>+		if (device->physical_device->rad_info.chip_class == SI) {
>+			unsigned fmask_bankh = util_logbase2(iview->image->fmask.bank_height);
>+			cb->cb_color_attrib |= S_028C74_FMASK_BANK_HEIGHT(fmask_bankh);
>+		}
>+	}
> 
> 	if (iview->image->cmask.size &&
> 	    !(device->debug_flags & RADV_DEBUG_NO_FAST_CLEARS))
>-- 
>2.9.4
>

Actions: View | Splinter Review

Attachments on bug 101334: 131788 | 131842 | 131874 | 131877 | 131878 | 131879 | 131985 | 131986 | 131987 | 133190 | 133252 | 133273 | 133274 | 133276

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.