Attachment 133830 Details for Bug 102450 – Patch that documents OutputDev::drawChar

[patch] Patch that documents OutputDev::drawChar

0003-Document-some-parameters-of-the-drawChar-method.patch (text/plain), 1.48 KB, created by oliver.sander on 2017-08-28 08:30:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: oliver.sander

Created: 2017-08-28 08:30:51 UTC

Size: 1.48 KB

patch

obsolete

>From a5289ec3a64dcbf8ae4b71a0af7282da1af8e0d9 Mon Sep 17 00:00:00 2001
>From: Oliver Sander <oliver.sander@tu-dresden.de>
>Date: Mon, 28 Aug 2017 10:25:12 +0200
>Subject: [PATCH 3/3] Document some parameters of the drawChar method
>
>Thanks to Adrian Johnson, who explained their meaning to me.
>---
> poppler/OutputDev.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
>diff --git a/poppler/OutputDev.h b/poppler/OutputDev.h
>index bc9fca07..0f60f60f 100644
>--- a/poppler/OutputDev.h
>+++ b/poppler/OutputDev.h
>@@ -249,6 +249,16 @@ public:
>   virtual void endStringOp(GfxState * /*state*/) {}
>   virtual void beginString(GfxState * /*state*/, GooString * /*s*/) {}
>   virtual void endString(GfxState * /*state*/) {}
>+
>+  // Draw one glyph at a specified position
>+  //
>+  // Arguments are:
>+  // CharCode code: This is the character code in the content stream. It needs to be mapped back to a glyph index.
>+  // int nBytes: The text strings in the content stream can consists of either 8-bit or 16-bit
>+  //             character codes depending on the font. nBytes is the number of bytes in the character code.
>+  // Unicode *u: The UCS-4 mapping used for text extraction (TextOutputDev).
>+  // int uLen: The number of unicode entries in u.  Usually '1', for a single character,
>+  //           but it may also have larger values, for example for ligatures.
>   virtual void drawChar(GfxState * /*state*/, double /*x*/, double /*y*/,
> 			double /*dx*/, double /*dy*/,
> 			double /*originX*/, double /*originY*/,
>-- 
>2.14.1
>

Actions: View | Splinter Review

Attachments on bug 102450: 133830

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.