Attachment 134545 Details for Bug 103015 – Windows: Use libtool support for compiling resources in tools/ too

[patch] Windows: Use libtool support for compiling resources in tools/ too

0002-Windows-Use-libtool-support-for-compiling-resources-.patch (text/plain), 1.06 KB, created by Simon McVittie on 2017-09-28 16:09:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2017-09-28 16:09:45 UTC

Size: 1.06 KB

patch

obsolete

>From 045ebedb484fc4f168e5dd1d1f5bd16af0b10aa8 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <smcv@collabora.com>
>Date: Thu, 28 Sep 2017 17:00:29 +0100
>Subject: [PATCH 2/3] Windows: Use libtool support for compiling resources in
> tools/ too
>
>We might as well be consistent with dbus/ here.
>
>Note that unlike the version in dbus/ we have to build a plain object
>file here, not a Libtool object (.o, not .lo) because it's going to
>go into an executable, not a shared library. That's the only difference.
>
>Signed-off-by: Simon McVittie <smcv@collabora.com>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=103015
>---
> tools/Makefile.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tools/Makefile.am b/tools/Makefile.am
>index 96ce03fa..b40349bc 100644
>--- a/tools/Makefile.am
>+++ b/tools/Makefile.am
>@@ -118,7 +118,7 @@ if DBUS_WIN
> SUFFIXES = .rc
> 
> .rc.o:
>-	$(WINDRES) $< -o $@
>+	$(LIBTOOL) $(AM_V_lt) --tag=RC $(AM_LIBTOOLFLAGS) $(LIBTOOLFLAGS) --mode=compile $(RC) $< -o $@
> 
> nodist_dbus_update_activation_environment_SOURCES = disable-uac.rc
> 
>-- 
>2.14.2
>

Actions: View | Splinter Review

Attachments on bug 103015: 134523 | 134534 | 134535 | 134536 | 134537 | 134544 | 134545 | 134546 | 134565 | 134695 | 134696 | 134703 | 134704 | 134716 | 134719 | 134882 | 134883 | 134885 | 134886 | 134887 | 134909 | 134910 | 134911 | 134913 | 134924

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.