Attachment 135116 Details for Bug 103488 – lib: move g_object_ref call for clarity

[patch] lib: move g_object_ref call for clarity

lib-move-gobjectref-call-for-clarity.patch (text/plain), 3.56 KB, created by Ray Strode [halfline] on 2017-10-27 17:24:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ray Strode [halfline]

Created: 2017-10-27 17:24:58 UTC

Size: 3.56 KB

patch

obsolete

>From 53b7b2abfafecea3a33b0017fea68f3fb223d3cd Mon Sep 17 00:00:00 2001
>From: Ray Strode <rstrode@redhat.com>
>Date: Wed, 27 Sep 2017 10:39:05 -0400
>Subject: [PATCH] lib: move g_object_ref call for clarity
>
>create_new_user creates an ActUser object and returns it to
>the caller.  Before returning the object, it also adds the
>object to a list of "new users" to track when it fully loads.
>
>It's idiomatic to return the original ref to the caller of
>a constructor, but create_new_user instead gives the original
>reference to the new_users list.  Their's no practical difference,
>but this commit moves the ref around for clarity.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=103488
>---
> src/libaccountsservice/act-user-manager.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/src/libaccountsservice/act-user-manager.c b/src/libaccountsservice/act-user-manager.c
>index 914a1c9..d866725 100644
>--- a/src/libaccountsservice/act-user-manager.c
>+++ b/src/libaccountsservice/act-user-manager.c
>@@ -816,65 +816,65 @@ static void
> add_session_for_user (ActUserManager *manager,
>                       ActUser        *user,
>                       const char     *ssid,
>                       gboolean        is_ours)
> {
>         g_hash_table_insert (manager->priv->sessions,
>                              g_strdup (ssid),
>                              g_object_ref (user));
> 
>         _act_user_add_session (user, ssid, is_ours);
>         g_debug ("ActUserManager: added session for %s", describe_user (user));
> }
> 
> static void
> set_has_multiple_users (ActUserManager *manager,
>                         gboolean        has_multiple_users)
> {
>         if (manager->priv->has_multiple_users != has_multiple_users) {
>                 manager->priv->has_multiple_users = has_multiple_users;
>                 g_object_notify (G_OBJECT (manager), "has-multiple-users");
>         }
> }
> 
> static ActUser *
> create_new_user (ActUserManager *manager)
> {
>         ActUser *user;
> 
>         user = g_object_new (ACT_TYPE_USER, NULL);
> 
>-        manager->priv->new_users = g_slist_prepend (manager->priv->new_users, user);
>+        manager->priv->new_users = g_slist_prepend (manager->priv->new_users, g_object_ref (user));
> 
>         g_signal_connect_object (user, "notify::is-loaded", G_CALLBACK (on_new_user_loaded), manager, 0);
> 
>-        return g_object_ref (user);
>+        return user;
> }
> 
> static void
> add_user (ActUserManager *manager,
>           ActUser        *user)
> {
>         const char *object_path;
> 
>         g_debug ("ActUserManager: tracking user '%s'", act_user_get_user_name (user));
>         if (act_user_is_system_account (user)) {
>                 g_hash_table_insert (manager->priv->system_users_by_name,
>                                      g_strdup (act_user_get_user_name (user)),
>                                      g_object_ref (user));
>         } else {
>                 g_hash_table_insert (manager->priv->normal_users_by_name,
>                                      g_strdup (act_user_get_user_name (user)),
>                                      g_object_ref (user));
>         }
> 
>         object_path = act_user_get_object_path (user);
>         if (object_path != NULL) {
>                 g_hash_table_replace (manager->priv->users_by_object_path,
>                                       (gpointer) object_path,
>                                       g_object_ref (user));
>         }
> 
>         g_signal_connect_object (user,
>                                  "sessions-changed",
>                                  G_CALLBACK (on_user_sessions_changed),
>                                  manager, 0);
>-- 
>2.14.2

Actions: View | Splinter Review

Attachments on bug 103488: 135116 | 135117 | 135118 | 135119 | 135120 | 135121 | 135122 | 135123 | 135124 | 135125 | 135126 | 135127 | 135128

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.