Attachment 136041 Details for Bug 103910 – subjectdn_mem_alloc.patch

[patch] subjectdn_mem_alloc.patch

subjectdn_mem_alloc.patch (text/plain), 2.63 KB, created by Theofilos Intzoglou on 2017-12-07 20:18:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Theofilos Intzoglou

Created: 2017-12-07 20:18:36 UTC

Size: 2.63 KB

patch

obsolete

>diff --git a/poppler/SignatureHandler.cc b/poppler/SignatureHandler.cc
>index bddc45fe..566ee583 100644
>--- a/poppler/SignatureHandler.cc
>+++ b/poppler/SignatureHandler.cc
>@@ -48,7 +48,7 @@ char *SignatureHandler::getSignerName()
>   return CERT_GetCommonName(&cert->subject);
> }
> 
>-const char * SignatureHandler::getSignerSubjectDN()
>+char * SignatureHandler::getSignerSubjectDN()
> {
>   if (!CMSSignerInfo)
>     return nullptr;
>@@ -56,7 +56,7 @@ const char * SignatureHandler::getSignerSubjectDN()
>   CERTCertificate *cert = NSS_CMSSignerInfo_GetSigningCertificate(CMSSignerInfo, CERT_GetDefaultCertDB());
>   if (!cert)
>     return nullptr;
>-  return cert->subjectName;
>+  return strdup(cert->subjectName);
> }
> 
> HASH_HashType SignatureHandler::getHashAlgorithm()
>diff --git a/poppler/SignatureHandler.h b/poppler/SignatureHandler.h
>index 3b2f62b9..a4d50689 100644
>--- a/poppler/SignatureHandler.h
>+++ b/poppler/SignatureHandler.h
>@@ -37,7 +37,7 @@ public:
>   ~SignatureHandler();
>   time_t getSigningTime();
>   char * getSignerName();
>-  const char * getSignerSubjectDN();
>+  char * getSignerSubjectDN();
>   HASH_HashType getHashAlgorithm();
>   void setSignature(unsigned char *, int);
>   void updateHash(unsigned char * data_block, int data_len);
>diff --git a/poppler/SignatureInfo.cc b/poppler/SignatureInfo.cc
>index 7ca8b969..98139c2b 100644
>--- a/poppler/SignatureInfo.cc
>+++ b/poppler/SignatureInfo.cc
>@@ -51,6 +51,7 @@ SignatureInfo::SignatureInfo(SignatureValidationStatus sig_val_status, Certifica
> SignatureInfo::~SignatureInfo()
> {
>   free(signer_name);
>+  free(subject_dn);
> }
> 
> /* GETTERS */
>@@ -103,8 +104,9 @@ void SignatureInfo::setSignerName(char *signerName)
>   signer_name = signerName;
> }
> 
>-void SignatureInfo::setSubjectDN(const char *subjectDN)
>+void SignatureInfo::setSubjectDN(char *subjectDN)
> {
>+  free(subject_dn);
>   subject_dn = subjectDN;
> }
> 
>diff --git a/poppler/SignatureInfo.h b/poppler/SignatureInfo.h
>index 35e7568c..dad9a035 100644
>--- a/poppler/SignatureInfo.h
>+++ b/poppler/SignatureInfo.h
>@@ -57,7 +57,7 @@ public:
>   void setSignatureValStatus(enum SignatureValidationStatus );
>   void setCertificateValStatus(enum CertificateValidationStatus );
>   void setSignerName(char *);
>-  void setSubjectDN(const char *);
>+  void setSubjectDN(char *);
>   void setHashAlgorithm(int);
>   void setSigningTime(time_t);
>   void setSubFilterSupport(bool isSupported) { sig_subfilter_supported = isSupported; }
>@@ -69,7 +69,7 @@ private:
>   SignatureValidationStatus sig_status;
>   CertificateValidationStatus cert_status;
>   char *signer_name;
>-  const char *subject_dn;
>+  char *subject_dn;
>   int hash_type;
>   time_t signing_time;
>   bool sig_subfilter_supported;

Actions: View | Splinter Review

Attachments on bug 103910: 135716 | 136041

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.