Attachment 136897 Details for Bug 104553 – attachment-29990-0.html

attachment-29990-0.html

attachment-29990-0.html (text/html), 4.43 KB, created by Ilia Mirkin on 2018-01-22 15:04:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ilia Mirkin

Created: 2018-01-22 15:04:07 UTC

Size: 4.43 KB

patch

obsolete

><div dir="auto">FYI idr had a separate script to reduce the giant test cases to the smallest that would still fail. It should be in one of his piglit branches in his personal fd.o git repo. (I&#39;m on the go, hence no specific URL.)</div><div class="gmail_extra"><br><div class="gmail_quote">On Jan 22, 2018 09:02,  &lt;<a href="mailto:bugzilla-daemon@freedesktop.org">bugzilla-daemon@freedesktop.org</a>&gt; wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
>    
>      
>    
>    <div><span class="m_-6079923891987839582vcard"><a class="m_-6079923891987839582email" href="mailto:florian.will@googlemail.com" title="florian.will@googlemail.com" target="_blank">florian.will@googlemail.com</a>
></span> changed
>          <a class="m_-6079923891987839582bz_bug_link m_-6079923891987839582bz_status_NEW" title="NEW - mat4: m[i][j] incorrect result with row_major UBO" href="https://bugs.freedesktop.org/show_bug.cgi?id=104553" target="_blank">bug 104553</a>
>          <br>
>             <table border="1" cellspacing="0" cellpadding="8">
>          <tr>
>            <th>What</th>
>            <th>Removed</th>
>            <th>Added</th>
>          </tr>
>
>         <tr>
>           <td style="text-align:right">Attachment #136630 is obsolete</td>
>           <td>
>               Â 
>           </td>
>           <td>1
>           </td>
>         </tr></table>
>      <p>
>        <div>
>            <b><a class="m_-6079923891987839582bz_bug_link m_-6079923891987839582bz_status_NEW" title="NEW - mat4: m[i][j] incorrect result with row_major UBO" href="https://bugs.freedesktop.org/show_bug.cgi?id=104553#c7" target="_blank">Comment # 7</a>
>              on <a class="m_-6079923891987839582bz_bug_link m_-6079923891987839582bz_status_NEW" title="NEW - mat4: m[i][j] incorrect result with row_major UBO" href="https://bugs.freedesktop.org/show_bug.cgi?id=104553" target="_blank">bug 104553</a>
>              from <span class="m_-6079923891987839582vcard"><a class="m_-6079923891987839582email" href="mailto:florian.will@googlemail.com" title="florian.will@googlemail.com" target="_blank">florian.will@googlemail.com</a>
></span></b>
>        <pre>Created <span><a href="https://bugs.freedesktop.org/attachment.cgi?id=136878" name="m_-6079923891987839582_attach_136878" title="Changes to piglit UBO test generator" target="_blank">attachment 136878</a> <a href="https://bugs.freedesktop.org/attachment.cgi?id=136878&amp;action=edit" title="Changes to piglit UBO test generator" target="_blank">[details]</a></span> <a href="https://bugs.freedesktop.org/page.cgi?id=splinter.html&amp;bug=104553&amp;attachment=136878" target="_blank">[review]</a>
>Changes to piglit UBO test generator
>
>I have now extended the random UBO piglit test generator python script (in a
>hackish way) to generate SSBO tests as well, and added std430 packing rules to
>generate std430 SSBO tests. My changes are in the attached patch file, but I&#39;d
>say it&#39;s not suitable for piglit git (too ugly).
>
>It was helpful to validate the mesa patch I&#39;ve attached to this bug report
>earlier. Using mesa git master, 391 out of the 540 generated UBO&amp;SSBO tests
>fail. After applying my patch, only a few tests (3-7) fail. The failing tests
>are always very huge test files (some have more than 10k lines and sometimes up
>to 5MB shader_test files). Apparently they hit something like an internal size
>limit for vertex shaders, because the tests pass when commenting out one half
>of the test conditions in the vertex shader, and they still pass when
>commenting out the other half of the vertex shader.
>
>So I&#39;m now fairly confident that my patch improves the SSBO / UBO buffer access
>behaviour when reading from SSBOs and UBOs.
>
>Is there anything else that should be tested? Or any comments about the patch
>by someone who knows the lower_buffer_access code better than I do?</pre>
>        </div>
>      </p>
>
>
>      <hr>
>      <span>You are receiving this mail because:</span>
>
>      <ul>
>          <li>You are the assignee for the bug.</li>
>      </ul>
>    </div>
><br>______________________________<wbr>_________________<br>
>mesa-dev mailing list<br>
><a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
><a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
><br></blockquote></div></div>

<div dir="auto">FYI idr had a separate script to reduce the giant test cases to the smallest that would still fail. It should be in one of his piglit branches in his personal fd.o git repo. (I&#39;m on the go, hence no specific URL.)</div><div class="gmail_extra"><br><div class="gmail_quote">On Jan 22, 2018 09:02,  &lt;<a href="mailto:bugzilla-daemon@freedesktop.org">bugzilla-daemon@freedesktop.org</a>&gt; wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
    
      
    
    <div><span class="m_-6079923891987839582vcard"><a class="m_-6079923891987839582email" href="mailto:florian.will@googlemail.com" title="florian.will@googlemail.com" target="_blank">florian.will@googlemail.com</a>
</span> changed
          <a class="m_-6079923891987839582bz_bug_link m_-6079923891987839582bz_status_NEW" title="NEW - mat4: m[i][j] incorrect result with row_major UBO" href="https://bugs.freedesktop.org/show_bug.cgi?id=104553" target="_blank">bug 104553</a>
          <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right">Attachment #136630 is obsolete</td>
           <td>
               Â 
           </td>
           <td>1
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="m_-6079923891987839582bz_bug_link m_-6079923891987839582bz_status_NEW" title="NEW - mat4: m[i][j] incorrect result with row_major UBO" href="https://bugs.freedesktop.org/show_bug.cgi?id=104553#c7" target="_blank">Comment # 7</a>
              on <a class="m_-6079923891987839582bz_bug_link m_-6079923891987839582bz_status_NEW" title="NEW - mat4: m[i][j] incorrect result with row_major UBO" href="https://bugs.freedesktop.org/show_bug.cgi?id=104553" target="_blank">bug 104553</a>
              from <span class="m_-6079923891987839582vcard"><a class="m_-6079923891987839582email" href="mailto:florian.will@googlemail.com" title="florian.will@googlemail.com" target="_blank">florian.will@googlemail.com</a>
</span></b>
        <pre>Created <span><a href="https://bugs.freedesktop.org/attachment.cgi?id=136878" name="m_-6079923891987839582_attach_136878" title="Changes to piglit UBO test generator" target="_blank">attachment 136878</a> <a href="https://bugs.freedesktop.org/attachment.cgi?id=136878&amp;action=edit" title="Changes to piglit UBO test generator" target="_blank">[details]</a></span> <a href="https://bugs.freedesktop.org/page.cgi?id=splinter.html&amp;bug=104553&amp;attachment=136878" target="_blank">[review]</a>
Changes to piglit UBO test generator

I have now extended the random UBO piglit test generator python script (in a
hackish way) to generate SSBO tests as well, and added std430 packing rules to
generate std430 SSBO tests. My changes are in the attached patch file, but I&#39;d
say it&#39;s not suitable for piglit git (too ugly).

It was helpful to validate the mesa patch I&#39;ve attached to this bug report
earlier. Using mesa git master, 391 out of the 540 generated UBO&amp;SSBO tests
fail. After applying my patch, only a few tests (3-7) fail. The failing tests
are always very huge test files (some have more than 10k lines and sometimes up
to 5MB shader_test files). Apparently they hit something like an internal size
limit for vertex shaders, because the tests pass when commenting out one half
of the test conditions in the vertex shader, and they still pass when
commenting out the other half of the vertex shader.

So I&#39;m now fairly confident that my patch improves the SSBO / UBO buffer access
behaviour when reading from SSBOs and UBOs.

Is there anything else that should be tested? Or any comments about the patch
by someone who knows the lower_buffer_access code better than I do?</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </div>
<br>______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
<br></blockquote></div></div>

Actions: View

Attachments on bug 104553: 136630 | 136648 | 136878 | 136897 | 144167

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.