Attachment 137087 Details for Bug 104597 – Possible fix, tested against server 1.19 branch.

[patch] Possible fix, tested against server 1.19 branch.

0001-glx-Only-assign-8-bpc-fbconfigs-for-composite-visual.patch (text/plain), 1.74 KB, created by Mario Kleiner on 2018-01-31 13:02:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mario Kleiner

Created: 2018-01-31 13:02:51 UTC

Size: 1.74 KB

patch

obsolete

>From 78f0dd649ef10aa04b8f64247e2414e1564e2ddf Mon Sep 17 00:00:00 2001
>From: Mario Kleiner <mario.kleiner.de@gmail.com>
>Date: Wed, 31 Jan 2018 07:09:23 +0100
>Subject: [PATCH xserver] glx: Only assign 8 bpc fbconfigs for composite
> visuals.
>
>Commit 91c42093b248 ("glx: Duplicate relevant fbconfigs for
>compositing visuals") adds many new depth 32 fbconfigs as
>composite visuals. On a X-Screen running at depth 24, this
>also adds bgra 10-10-10-2 fbconigs, as they also have
>config.rgbBits == 32, but these are not displayable on a
>depth 24 screen, leading to visually corrupted desktops
>under some compositors, e.g., fdo bug 104597 "Compton
>weird colors" when running compton with
>"compton --backend glx".
>
>Be more conservative for now and only select fbconfigs with
>8 bpc red, green, blue components for composite visuals.
>
>Fixes: 91c42093b248 ("glx: Duplicate relevant fbconfigs for
>                      compositing visuals")
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104597
>Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
>Cc: Thomas Hellstrom <thellstrom@vmware.com>
>Cc: Adam Jackson <ajax@redhat.com>
>---
> glx/glxdricommon.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/glx/glxdricommon.c b/glx/glxdricommon.c
>index d3136e8..dbf199c 100644
>--- a/glx/glxdricommon.c
>+++ b/glx/glxdricommon.c
>@@ -218,6 +218,9 @@ createModeFromConfig(const __DRIcoreExtension * core,
>     if (duplicateForComp &&
>         (render_type_is_pbuffer_only(renderType) ||
>          config->config.rgbBits != 32 ||
>+         config->config.redBits != 8 ||
>+         config->config.greenBits != 8 ||
>+         config->config.blueBits != 8 ||
>          config->config.visualRating != GLX_NONE ||
>          config->config.sampleBuffers != 0)) {
>         free(config);
>-- 
>2.7.4
>

Actions: View | Splinter Review

Attachments on bug 104597: 136675 | 136700 | 136701 | 137087

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.