Attachment 137324 Details for Bug 105018 – Patch 3 Clean up formatting in irq_service_dce110.c

[patch] Patch 3 Clean up formatting in irq_service_dce110.c

0003-drm-amd-display-Clean-up-formatting-in-irq_service_d.patch (text/plain), 4.54 KB, created by Harry Wentland on 2018-02-13 16:13:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Harry Wentland

Created: 2018-02-13 16:13:58 UTC

Size: 4.54 KB

patch

obsolete

>From 35c1474f61666efe437ff5a16144a297843df39c Mon Sep 17 00:00:00 2001
>From: Harry Wentland <harry.wentland@amd.com>
>Date: Tue, 13 Feb 2018 11:07:07 -0500
>Subject: [PATCH 3/4] drm/amd/display: Clean up formatting in
> irq_service_dce110.c
>
>Signed-off-by: Harry Wentland <harry.wentland@amd.com>
>---
> .../amd/display/dc/irq/dce110/irq_service_dce110.c | 73 +++++++++-------------
> 1 file changed, 31 insertions(+), 42 deletions(-)
>
>diff --git a/drivers/gpu/drm/amd/display/dc/irq/dce110/irq_service_dce110.c b/drivers/gpu/drm/amd/display/dc/irq/dce110/irq_service_dce110.c
>index f7e40b292dfb..0dab890abb9f 100644
>--- a/drivers/gpu/drm/amd/display/dc/irq/dce110/irq_service_dce110.c
>+++ b/drivers/gpu/drm/amd/display/dc/irq/dce110/irq_service_dce110.c
>@@ -36,27 +36,23 @@
> 
> #include "dc.h"
> #include "core_types.h"
>-static bool hpd_ack(
>-	struct irq_service *irq_service,
>-	const struct irq_source_info *info)
>+
>+static bool hpd_ack(struct irq_service *irq_service,
>+		    const struct irq_source_info *info)
> {
> 	uint32_t addr = info->status_reg;
> 	uint32_t value = dm_read_reg(irq_service->ctx, addr);
>-	uint32_t current_status =
>-		get_reg_field_value(
>-			value,
>-			DC_HPD_INT_STATUS,
>-			DC_HPD_SENSE_DELAYED);
>+	uint32_t current_status = get_reg_field_value(value,
>+						      DC_HPD_INT_STATUS,
>+						      DC_HPD_SENSE_DELAYED);
> 
> 	dal_irq_service_ack_generic(irq_service, info);
> 
> 	value = dm_read_reg(irq_service->ctx, info->enable_reg);
> 
>-	set_reg_field_value(
>-		value,
>-		current_status ? 0 : 1,
>-		DC_HPD_INT_CONTROL,
>-		DC_HPD_INT_POLARITY);
>+	set_reg_field_value(value, current_status ? 0 : 1,
>+			    DC_HPD_INT_CONTROL,
>+			    DC_HPD_INT_POLARITY);
> 
> 	dm_write_reg(irq_service->ctx, info->enable_reg, value);
> 
>@@ -176,41 +172,36 @@ static const struct irq_source_info_funcs vblank_irq_info_funcs = {
> #define dc_underflow_int_entry(reg_num) \
> 	[DC_IRQ_SOURCE_DC ## reg_num ## UNDERFLOW] = dummy_irq_entry()
> 
>-bool dal_irq_service_dummy_set(
>-	struct irq_service *irq_service,
>-	const struct irq_source_info *info,
>-	bool enable)
>+bool dal_irq_service_dummy_set(struct irq_service *irq_service,
>+			       const struct irq_source_info *info,
>+			       bool enable)
> {
>-	dm_logger_write(
>-		irq_service->ctx->logger, LOG_ERROR,
>-		"%s: called for non-implemented irq source\n",
>-		__func__);
>+	dm_logger_write(irq_service->ctx->logger, LOG_ERROR,
>+			"%s: called for non-implemented irq source\n",
>+			__func__);
> 	return false;
> }
> 
>-bool dal_irq_service_dummy_ack(
>-	struct irq_service *irq_service,
>-	const struct irq_source_info *info)
>+bool dal_irq_service_dummy_ack(struct irq_service *irq_service,
>+			       const struct irq_source_info *info)
> {
>-	dm_logger_write(
>-		irq_service->ctx->logger, LOG_ERROR,
>-		"%s: called for non-implemented irq source\n",
>-		__func__);
>+	dm_logger_write(irq_service->ctx->logger, LOG_ERROR,
>+			"%s: called for non-implemented irq source\n",
>+			__func__);
> 	return false;
> }
> 
> 
>-bool dce110_vblank_set(
>-		struct irq_service *irq_service,
>-		const struct irq_source_info *info,
>-		bool enable)
>+bool dce110_vblank_set(struct irq_service *irq_service,
>+		       const struct irq_source_info *info,
>+		       bool enable)
> {
> 	struct dc_context *dc_ctx = irq_service->ctx;
> 	struct dc *core_dc = irq_service->ctx->dc;
>-	enum dc_irq_source dal_irq_src = dc_interrupt_to_irq_source(
>-										irq_service->ctx->dc,
>-										info->src_id,
>-										info->ext_id);
>+	enum dc_irq_source dal_irq_src =
>+			dc_interrupt_to_irq_source(irq_service->ctx->dc,
>+						   info->src_id,
>+						   info->ext_id);
> 	uint8_t pipe_offset = dal_irq_src - IRQ_TYPE_VBLANK;
> 
> 	struct timing_generator *tg =
>@@ -225,7 +216,6 @@ bool dce110_vblank_set(
> 
> 	dal_irq_service_set_generic(irq_service, info, enable);
> 	return true;
>-
> }
> 
> static const struct irq_source_info_funcs dummy_irq_info_funcs = {
>@@ -406,9 +396,8 @@ static const struct irq_service_funcs irq_service_funcs_dce110 = {
> 		.to_dal_irq_source = to_dal_irq_source_dce110
> };
> 
>-static void construct(
>-	struct irq_service *irq_service,
>-	struct irq_service_init_data *init_data)
>+static void construct(struct irq_service *irq_service,
>+		      struct irq_service_init_data *init_data)
> {
> 	dal_irq_service_construct(irq_service, init_data);
> 
>@@ -416,8 +405,8 @@ static void construct(
> 	irq_service->funcs = &irq_service_funcs_dce110;
> }
> 
>-struct irq_service *dal_irq_service_dce110_create(
>-	struct irq_service_init_data *init_data)
>+struct irq_service *
>+dal_irq_service_dce110_create(struct irq_service_init_data *init_data)
> {
> 	struct irq_service *irq_service = kzalloc(sizeof(*irq_service),
> 						  GFP_KERNEL);
>-- 
>2.14.1
>

Actions: View | Splinter Review

Attachments on bug 105018: 137308 | 137322 | 137323 | 137324 | 137325 | 137327 | 137383

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.