Attachment 138814 Details for Bug 106006 – [PATCH] drm/amd/display: Don't program bypass on linear regamma LUT

[patch] [PATCH] drm/amd/display: Don't program bypass on linear regamma LUT

0001-drm-amd-display-Don-t-program-bypass-on-linear-regam.patch (text/plain), 1.89 KB, created by Harry Wentland on 2018-04-12 20:50:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Harry Wentland

Created: 2018-04-12 20:50:09 UTC

Size: 1.89 KB

patch

obsolete

>From 9adc614f258ba021aa70eeed92ecb0613406cf09 Mon Sep 17 00:00:00 2001
>From: Harry Wentland <harry.wentland@amd.com>
>Date: Thu, 12 Apr 2018 16:37:09 -0400
>Subject: [PATCH] drm/amd/display: Don't program bypass on linear regamma LUT
>
>Even though this is required for degamma since DCE HW only supports a
>couple predefined LUTs we can just program the LUT directly.
>
>This fixes dark screens which occurs when we program regamma to bypass
>while degamma is using srgb LUT.
>
>Signed-off-by: Harry Wentland <harry.wentland@amd.com>
>---
> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c  | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
>diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c
>index ef5fad8c5aac..59e993ad1209 100644
>--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c
>+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c
>@@ -133,19 +133,15 @@ int amdgpu_dm_set_regamma_lut(struct dm_crtc_state *crtc)
> 		/* By default, use the SRGB predefined curve.*/
> 		stream->out_transfer_func->type = TF_TYPE_PREDEFINED;
> 		stream->out_transfer_func->tf = TRANSFER_FUNCTION_SRGB;
>+
>+		DRM_DEBUG_KMS("Using pre-defined regamma\n");
>+
> 		return 0;
> 	}
> 
> 	lut = (struct drm_color_lut *)blob->data;
> 	lut_size = blob->length / sizeof(struct drm_color_lut);
> 
>-	if (__is_lut_linear(lut, lut_size)) {
>-		/* Set to bypass if lut is set to linear */
>-		stream->out_transfer_func->type = TF_TYPE_BYPASS;
>-		stream->out_transfer_func->tf = TRANSFER_FUNCTION_LINEAR;
>-		return 0;
>-	}
>-
> 	gamma = dc_create_gamma();
> 	if (!gamma)
> 		return -ENOMEM;
>@@ -161,6 +157,8 @@ int amdgpu_dm_set_regamma_lut(struct dm_crtc_state *crtc)
> 		return -EINVAL;
> 	}
> 
>+	DRM_DEBUG_KMS("Using regamma with %d entries\n", lut_size);
>+
> 	/* Convert drm_lut into dc_gamma */
> 	__drm_lut_to_dc_gamma(lut, gamma, gamma->type == GAMMA_RGB_256);
> 
>-- 
>2.17.0
>

Actions: View | Splinter Review

Attachments on bug 106006: 138804 | 138805 | 138806 | 138807 | 138808 | 138809 | 138814 | 139022

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.