Attachment 140253 Details for Bug 106258 – Refining the amdgpu_vm.c:amdgpu_vm_bo_split_mapping further

[patch] Refining the amdgpu_vm.c:amdgpu_vm_bo_split_mapping further

file_106258.txt (text/plain), 2.26 KB, created by Ben Crocker on 2018-06-20 22:39:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ben Crocker

Created: 2018-06-20 22:39:00 UTC

Size: 2.26 KB

patch

obsolete

>From e4dfb36c1b07e4aef7988170017a916baa1a469b Mon Sep 17 00:00:00 2001
>From: Ben Crocker <bcrocker@redhat.com>
>Date: Wed, 20 Jun 2018 18:36:50 -0400
>Subject: [PATCH] Additional debug output: amdgpu_vm_bo_split_mapping: print
> max_entries in both decimal and hex
>
>Signed-off-by: Ben Crocker <bcrocker@redhat.com>
>---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>index 04fea8de61a8..1e64487ee9f8 100644
>--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>@@ -1439,7 +1439,7 @@ static int amdgpu_vm_bo_split_mapping(struct amdgpu_device *adev,
> 			max_entries = (nodes->size - pfn) *
> 				(PAGE_SIZE / AMDGPU_GPU_PAGE_SIZE);
> 			DRM_INFO_ONCE("amdgpu_vm_bo_split_mapping: PAGE_SIZE=%lu PAGE_SHIFT=%u\n", PAGE_SIZE, PAGE_SHIFT);
>-			DRM_INFO("amdgpu_vm_bo_split_mapping nodes->size=%llu pfn=%llu max_entries=%llu\n", nodes->size, pfn, max_entries);
>+			DRM_INFO("amdgpu_vm_bo_split_mapping nodes->size=%llu pfn=%llu max_entries=%llu (%#llx)\n", nodes->size, pfn, max_entries, max_entries);
> 		} else {
> 			addr = 0;
> 			max_entries = S64_MAX;
>@@ -1449,7 +1449,7 @@ static int amdgpu_vm_bo_split_mapping(struct amdgpu_device *adev,
> 			uint64_t count;
> 
> 			max_entries = min(max_entries, 16ull * 1024ull);
>-			DRM_INFO("amdgpu_vm_bo_split_mapping: max_entries=%llu\n", max_entries);
>+			DRM_INFO("amdgpu_vm_bo_split_mapping: max_entries=%llu (%#llx)\n", max_entries, max_entries);
> 			for (count = 1; count < max_entries; ++count) {
> 				uint64_t idx = pfn + count;
> 
>@@ -1465,7 +1465,7 @@ static int amdgpu_vm_bo_split_mapping(struct amdgpu_device *adev,
> 				addr = pages_addr[pfn];
> 				max_entries = count;
> 			}
>-			DRM_INFO("amdgpu_vm_bo_split_mapping: addr=%#llx count=%llu max_entries=%llu\n", addr, count, max_entries);
>+			DRM_INFO("amdgpu_vm_bo_split_mapping: addr=%#llx count=%llu max_entries=%llu (%#llx)\n", addr, count, max_entries, max_entries);
> 		} else if (flags & AMDGPU_PTE_VALID) {
> 			DRM_INFO("amdgpu_vm_bo_split_mapping: addr=%#llx vram_base_offset=%#llx\n", addr, adev->vm_manager.vram_base_offset);
> 			addr += adev->vm_manager.vram_base_offset;
>-- 
>2.13.6
>

Actions: View | Splinter Review

Attachments on bug 106258: 140046 | 140208 | 140239 | 140252 | 140253 | 140257

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.