Attachment 140930 Details for Bug 106846 – [PATCH] Report non-DP display as disconnected without EDID

[patch] [PATCH] Report non-DP display as disconnected without EDID

0001-drm-amd-display-Report-non-DP-display-as-disconnecte.patch (text/plain), 1.48 KB, created by Harry Wentland on 2018-08-01 19:49:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Harry Wentland

Created: 2018-08-01 19:49:41 UTC

Size: 1.48 KB

patch

obsolete

>From 54666751bee87d13db45fd2cefc8a8b7f3eeec64 Mon Sep 17 00:00:00 2001
>From: Harry Wentland <harry.wentland@amd.com>
>Date: Wed, 1 Aug 2018 10:48:23 -0400
>Subject: [PATCH] drm/amd/display: Report non-DP display as disconnected
> without EDID
>
>[Why]
>Some boards seem to have a problem where HPD is high on HDMI even though
>no display is connected. We don't want to report these as connected. DP
>spec still requires us to report DP displays as connected when HPD is
>high but we can't read the EDID in order to go to fail-safe mode.
>
>[How]
>If connector_signal is not DP abort detection if we can't retrieve the
>EDID.
>
>Signed-off-by: Harry Wentland <harry.wentland@amd.com>
>---
> drivers/gpu/drm/amd/display/dc/core/dc_link.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
>diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
>index b180197a41e2..84f0fd15be4c 100644
>--- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
>+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
>@@ -744,6 +744,17 @@ bool dc_link_detect(struct dc_link *link, enum dc_detect_reason reason)
> 			break;
> 		case EDID_NO_RESPONSE:
> 			DC_LOG_ERROR("No EDID read.\n");
>+
>+			/*
>+			 * Abort detection for non-DP connectors if we have
>+			 * no EDID
>+			 *
>+			 * DP needs to report as connected if HDP is high
>+			 * even if we have no EDID in order to go to
>+			 * fail-safe mode
>+			 */
>+			if (!dc_is_dp_signal(link->connector_signal))
>+				return false;
> 		default:
> 			break;
> 		}
>-- 
>2.17.1
>

Actions: View | Splinter Review

Attachments on bug 106846: 140060 | 140061 | 140062 | 140064 | 140930

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.