Attachment 141427 Details for Bug 107447 – Test fix patch

[patch] Test fix patch

0001-drm-nouveau-Don-t-disable-polling-in-fallback-mode.patch (text/plain), 1.35 KB, created by Takashi Iwai on 2018-09-03 15:23:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Takashi Iwai

Created: 2018-09-03 15:23:35 UTC

Size: 1.35 KB

patch

obsolete

>From 3639c381cdf5fa4340cbc2c7f34e2b526a6f6a6b Mon Sep 17 00:00:00 2001
>From: Takashi Iwai <tiwai@suse.de>
>Date: Fri, 31 Aug 2018 12:03:28 +0200
>Subject: [PATCH] drm/nouveau: Don't disable polling in fallback mode
>
>When a fan is controlled via linear fallback without cstate, we
>shouldn't stop polling.  Otherwise it won't be adjusted again and
>keeps running at an initial crazy pace.
>
>Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=1103356
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107447
>Reported-by: Thomas Blume <thomas.blume@suse.com>
>Signed-off-by: Takashi Iwai <tiwai@suse.de>
>---
> drivers/gpu/drm/nouveau/nvkm/subdev/therm/base.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/base.c b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/base.c
>index 3695cde669f8..07914e36939e 100644
>--- a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/base.c
>+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/base.c
>@@ -132,11 +132,12 @@ nvkm_therm_update(struct nvkm_therm *therm, int mode)
> 			duty = nvkm_therm_update_linear(therm);
> 			break;
> 		case NVBIOS_THERM_FAN_OTHER:
>-			if (therm->cstate)
>+			if (therm->cstate) {
> 				duty = therm->cstate;
>-			else
>+				poll = false;
>+			} else {
> 				duty = nvkm_therm_update_linear_fallback(therm);
>-			poll = false;
>+			}
> 			break;
> 		}
> 		immd = false;
>-- 
>2.18.0
>

Actions: View | Splinter Review

Attachments on bug 107447: 140926 | 140927 | 141427

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.