Attachment 142333 Details for Bug 108546 – I915-DEBUG printks

[patch] I915-DEBUG printks

0001-I915-DEBUG-Check-which-display-connection-path-we-ar.patch (text/plain), 4.51 KB, created by Rodrigo Vivi on 2018-11-02 00:19:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Rodrigo Vivi

Created: 2018-11-02 00:19:34 UTC

Size: 4.51 KB

patch

obsolete

>From 8260ac6ec6ed23bf5ab4d37890cf23769100bb60 Mon Sep 17 00:00:00 2001
>From: Rodrigo Vivi <rodrigo.vivi@intel.com>
>Date: Thu, 1 Nov 2018 17:11:42 -0700
>Subject: [PATCH] I915-DEBUG: Check which display connection path we are
> taking.
>
>New TC component on ICL requires an interaction with a TC
>firmware.
>
>There is a mechanism for handshaking to see when TC port needs
>to be used.
>
>I double checked the spec and our sequences seems to be right,
>but I suspect on some interactions with firmware.
>
>But before any conclusion I'd like to know exactly which path
>our code is taking.
>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107724
>Cc: Takashi Iwai <tiwai@suse.de>
>Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>---
> drivers/gpu/drm/i915/intel_dp.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
>diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
>index 9a2db61c1ba7..c910bb0dc458 100644
>--- a/drivers/gpu/drm/i915/intel_dp.c
>+++ b/drivers/gpu/drm/i915/intel_dp.c
>@@ -4996,6 +4996,7 @@ static bool icl_combo_port_connected(struct drm_i915_private *dev_priv,
> {
> 	enum port port = intel_dig_port->base.port;
> 
>+	DRM_ERROR("I915-DEBUG: %s %d\n", __FUNCTION__, __LINE__);
> 	return I915_READ(SDEISR) & SDE_DDI_HOTPLUG_ICP(port);
> }
> 
>@@ -5009,6 +5010,7 @@ static void icl_update_tc_port_type(struct drm_i915_private *dev_priv,
> 
> 	WARN_ON(is_legacy + is_typec + is_tbt != 1);
> 
>+	DRM_ERROR("I915-DEBUG: %s %d\n", __FUNCTION__, __LINE__);
> 	if (is_legacy) {
> 		intel_dig_port->tc_type = TC_PORT_LEGACY;
> 		type_str = "legacy";
>@@ -5022,6 +5024,7 @@ static void icl_update_tc_port_type(struct drm_i915_private *dev_priv,
> 		return;
> 	}
> 
>+	DRM_ERROR("I915-DEBUG: %s %d %s\n", __FUNCTION__, __LINE__, type_str);
> 	/* Types are not supposed to be changed at runtime. */
> 	WARN_ON(old_type != TC_PORT_UNKNOWN &&
> 		old_type != intel_dig_port->tc_type);
>@@ -5061,10 +5064,12 @@ static bool icl_tc_phy_connect(struct drm_i915_private *dev_priv,
> 	enum tc_port tc_port = intel_port_to_tc(dev_priv, dig_port->base.port);
> 	u32 val;
> 
>+	DRM_ERROR("I915-DEBUG: %s %d\n", __FUNCTION__, __LINE__);
> 	if (dig_port->tc_type != TC_PORT_LEGACY &&
> 	    dig_port->tc_type != TC_PORT_TYPEC)
> 		return true;
> 
>+	DRM_ERROR("I915-DEBUG: %s %d\n", __FUNCTION__, __LINE__);
> 	val = I915_READ(PORT_TX_DFLEXDPPMS);
> 	if (!(val & DP_PHY_MODE_STATUS_COMPLETED(tc_port))) {
> 		DRM_DEBUG_KMS("DP PHY for TC port %d not ready\n", tc_port);
>@@ -5077,6 +5082,7 @@ static bool icl_tc_phy_connect(struct drm_i915_private *dev_priv,
> 	 */
> 	val = I915_READ(PORT_TX_DFLEXDPCSSS);
> 	if (!(val & DP_PHY_MODE_STATUS_NOT_SAFE(tc_port))) {
>+		DRM_ERROR("I915-DEBUG: %s %d\n", __FUNCTION__, __LINE__);
> 		val |= DP_PHY_MODE_STATUS_NOT_SAFE(tc_port);
> 		I915_WRITE(PORT_TX_DFLEXDPCSSS, val);
> 	}
>@@ -5092,6 +5098,7 @@ static bool icl_tc_phy_connect(struct drm_i915_private *dev_priv,
> 		return false;
> 	}
> 
>+	DRM_ERROR("I915-DEBUG: %s %d\n", __FUNCTION__, __LINE__);
> 	return true;
> }
> 
>@@ -5104,9 +5111,11 @@ static void icl_tc_phy_disconnect(struct drm_i915_private *dev_priv,
> {
> 	enum tc_port tc_port = intel_port_to_tc(dev_priv, dig_port->base.port);
> 
>+	DRM_ERROR("I915-DEBUG: %s %d\n", __FUNCTION__, __LINE__);
> 	if (dig_port->tc_type == TC_PORT_UNKNOWN)
> 		return;
> 
>+	DRM_ERROR("I915-DEBUG: %s %d\n", __FUNCTION__, __LINE__);
> 	/*
> 	 * TBT disconnection flow is read the live status, what was done in
> 	 * caller.
>@@ -5115,6 +5124,7 @@ static void icl_tc_phy_disconnect(struct drm_i915_private *dev_priv,
> 	    dig_port->tc_type == TC_PORT_LEGACY) {
> 		u32 val;
> 
>+		DRM_ERROR("I915-DEBUG: %s %d\n", __FUNCTION__, __LINE__);
> 		val = I915_READ(PORT_TX_DFLEXDPCSSS);
> 		val &= ~DP_PHY_MODE_STATUS_NOT_SAFE(tc_port);
> 		I915_WRITE(PORT_TX_DFLEXDPCSSS, val);
>@@ -5141,6 +5151,7 @@ static bool icl_tc_port_connected(struct drm_i915_private *dev_priv,
> 	bool is_legacy, is_typec, is_tbt;
> 	u32 dpsp;
> 
>+	DRM_ERROR("I915-DEBUG: %s %d\n", __FUNCTION__, __LINE__);
> 	is_legacy = I915_READ(SDEISR) & SDE_TC_HOTPLUG_ICP(tc_port);
> 
> 	/*
>@@ -5153,15 +5164,18 @@ static bool icl_tc_port_connected(struct drm_i915_private *dev_priv,
> 
> 	if (!is_legacy && !is_typec && !is_tbt) {
> 		icl_tc_phy_disconnect(dev_priv, intel_dig_port);
>+		DRM_ERROR("I915-DEBUG: %s %d\n", __FUNCTION__, __LINE__);
> 		return false;
> 	}
> 
> 	icl_update_tc_port_type(dev_priv, intel_dig_port, is_legacy, is_typec,
> 				is_tbt);
> 
>+	DRM_ERROR("I915-DEBUG: %s %d\n", __FUNCTION__, __LINE__);
> 	if (!icl_tc_phy_connect(dev_priv, intel_dig_port))
> 		return false;
> 
>+	DRM_ERROR("I915-DEBUG: %s %d\n", __FUNCTION__, __LINE__);
> 	return true;
> }
> 
>-- 
>2.19.1
>

Actions: View | Splinter Review

Attachments on bug 108546: 142188 | 142189 | 142258 | 142259 | 142333 | 142371 | 142372

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.