Attachment 142666 Details for Bug 108912 – 0001-drm-amd-display-Fix-NULL-ptr-deref-for-commit_planes.patch

[patch] 0001-drm-amd-display-Fix-NULL-ptr-deref-for-commit_planes.patch

0001-drm-amd-display-Fix-NULL-ptr-deref-for-commit_planes.patch (text/plain), 1.47 KB, created by Nicholas Kazlauskas on 2018-11-30 15:08:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nicholas Kazlauskas

Created: 2018-11-30 15:08:16 UTC

Size: 1.47 KB

patch

obsolete

>From df94d42a355715f4a1b9ab695c1d18f9f89c05c4 Mon Sep 17 00:00:00 2001
>From: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
>Date: Fri, 30 Nov 2018 09:56:02 -0500
>Subject: [PATCH] drm/amd/display: Fix NULL ptr deref for
> commit_planes_to_stream
>
>[Why]
>With scaling, underscan and abm changes we can end up calling
>commit_planes_to_stream in commit_tail. This call uses dm_state->context
>which can be NULL if the commit was a fast update.
>
>[How]
>Use dc_state instead since that can't be NULL unless the system ran
>out of memory.
>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108912
>Fixes: e64abff2f133 ("drm/amd/display: Use private obj helpers for dm_atomic_state")
>
>Cc: Leo Li <sunpeng.li@amd.com>
>Cc: Harry Wentland <harry.wentland@amd.com>
>Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
>---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>index 76b1aebdca0c..8ecd78657d43 100644
>--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>@@ -5011,7 +5011,7 @@ static void amdgpu_dm_atomic_commit_tail(struct drm_atomic_state *state)
> 				status->plane_count,
> 				dm_new_crtc_state,
> 				to_dm_crtc_state(old_crtc_state),
>-				dm_state->context))
>+				dc_state))
> 			dm_error("%s: Failed to update stream scaling!\n", __func__);
> 	}
> 
>-- 
>2.19.2
>

Actions: View | Splinter Review

Attachments on bug 108912: 142663 | 142666

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.