Attachment 144249 Details for Bug 105406 – [PATCH 2/2] drm/i915: Skip SINK_COUNT read on CH7511

[patch] [PATCH 2/2] drm/i915: Skip SINK_COUNT read on CH7511

0002-drm-i915-Skip-SINK_COUNT-read-on-CH7511.patch (text/plain), 2.30 KB, created by Ville Syrjala on 2019-05-13 16:22:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ville Syrjala

Created: 2019-05-13 16:22:13 UTC

Size: 2.30 KB

patch

obsolete

>From a85a732a3b118a7b4fc588e97723d1982e40dd54 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= <ville.syrjala@linux.intel.com>
>Date: Mon, 13 May 2019 19:03:34 +0300
>Subject: [PATCH 2/2] drm/i915: Skip SINK_COUNT read on CH7511
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>CH7511 doesn't update SINK_COUNT properly so in order to detect
>the device as connected we have to ignore SINK_COUNT.
>
>In order to have access to the quirk list early enough we
>must move the drm_dp_read_desc() call to happen earlier.
>We can also skip re-reading this on eDP since we know it
>won't change.
>
>Cc: David S. <david@majinbuu.com>
>Cc: Peteris Rudzusiks <peteris.rudzusiks@gmail.com>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105406
>Signed-off-by: Ville SyrjÃ¤lÃ¤ <ville.syrjala@linux.intel.com>
>---
> drivers/gpu/drm/i915/intel_dp.c | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
>index 53cc4afea256..4bcb5267a65a 100644
>--- a/drivers/gpu/drm/i915/intel_dp.c
>+++ b/drivers/gpu/drm/i915/intel_dp.c
>@@ -4175,8 +4175,14 @@ intel_dp_get_dpcd(struct intel_dp *intel_dp)
> 	if (!intel_dp_read_dpcd(intel_dp))
> 		return false;
> 
>-	/* Don't clobber cached eDP rates. */
>+	/*
>+	 * Don't clobber cached eDP rates. Also skip re-reading
>+	 * the OUI/ID since we know it won't change.
>+	 */
> 	if (!intel_dp_is_edp(intel_dp)) {
>+		drm_dp_read_desc(&intel_dp->aux, &intel_dp->desc,
>+				 drm_dp_is_branch(intel_dp->dpcd));
>+
> 		intel_dp_set_sink_rates(intel_dp);
> 		intel_dp_set_common_rates(intel_dp);
> 	}
>@@ -4185,7 +4191,8 @@ intel_dp_get_dpcd(struct intel_dp *intel_dp)
> 	 * Some eDP panels do not set a valid value for sink count, that is why
> 	 * it don't care about read it here and in intel_edp_init_dpcd().
> 	 */
>-	if (!intel_dp_is_edp(intel_dp)) {
>+	if (!intel_dp_is_edp(intel_dp) &&
>+	    !drm_dp_has_quirk(&intel_dp->desc, DP_DPCD_QUIRK_NO_SINK_COUNT)) {
> 		u8 count;
> 		ssize_t r;
> 
>@@ -5422,9 +5429,6 @@ intel_dp_detect(struct drm_connector *connector,
> 	if (INTEL_GEN(dev_priv) >= 11)
> 		intel_dp_get_dsc_sink_cap(intel_dp);
> 
>-	drm_dp_read_desc(&intel_dp->aux, &intel_dp->desc,
>-			 drm_dp_is_branch(intel_dp->dpcd));
>-
> 	intel_dp_configure_mst(intel_dp);
> 
> 	if (intel_dp->is_mst) {
>-- 
>2.21.0
>

Actions: View | Splinter Review

Attachments on bug 105406: 138112 | 138133 | 139221 | 139222 | 144239 | 144247 | 144248 | 144249

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.