Attachment 24170 Details for Bug 20803 – GTT mapping fix

[patch] GTT mapping fix

i830-uxa-use-gtt-mapping.txt (text/plain), 2.05 KB, created by Jesse Barnes on 2009-03-23 11:58:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jesse Barnes

Created: 2009-03-23 11:58:29 UTC

Size: 2.05 KB

patch

obsolete

>diff --git a/src/i830_exa.c b/src/i830_exa.c
>index 0a22486..0a262bd 100644
>--- a/src/i830_exa.c
>+++ b/src/i830_exa.c
>@@ -37,6 +37,7 @@ SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
> #include "i810_reg.h"
> #include "i915_drm.h"
> #include <string.h>
>+#include <sys/mman.h>
> 
> #define ALWAYS_SYNC		0
> #define ALWAYS_FLUSH		0
>@@ -837,8 +838,6 @@ i830_uxa_set_pixmap_bo (PixmapPtr pixmap, dri_bo *bo)
> static Bool
> i830_uxa_prepare_access (PixmapPtr pixmap, uxa_access_t access)
> {
>-    ScrnInfoPtr pScrn = xf86Screens[pixmap->drawable.pScreen->myNum];
>-    I830Ptr pI830 = I830PTR(pScrn);
>     dri_bo *bo = i830_get_pixmap_bo (pixmap);
> 
>     if (bo) {
>@@ -853,16 +852,12 @@ i830_uxa_prepare_access (PixmapPtr pixmap, uxa_access_t access)
> 	    i830->need_sync = FALSE;
> 	}
> 
>-	if (pScrn->vtSema && !pI830->use_drm_mode && pI830->memory_manager) {
>-	    if (drm_intel_bo_pin(bo, 4096) != 0)
>-		return FALSE;
>-	    drm_intel_gem_bo_start_gtt_access(bo, access == UXA_ACCESS_RW);
>-	    pixmap->devPrivate.ptr = pI830->FbBase + bo->offset;
>-	} else {
>-	    if (dri_bo_map(bo, access == UXA_ACCESS_RW) != 0)
>-		return FALSE;
>-	    pixmap->devPrivate.ptr = bo->virtual;
>+	if (drm_intel_gem_bo_map_gtt(bo)) {
>+	    xf86DrvMsg(scrn->scrnIndex, X_WARNING, "%s: bo map failed\n",
>+		       __FUNCTION__);
>+	    return FALSE;
> 	}
>+	pixmap->devPrivate.ptr = bo->virtual;
>     }
>     return TRUE;
> }
>@@ -870,8 +865,6 @@ i830_uxa_prepare_access (PixmapPtr pixmap, uxa_access_t access)
> static void
> i830_uxa_finish_access (PixmapPtr pixmap)
> {
>-    ScrnInfoPtr pScrn = xf86Screens[pixmap->drawable.pScreen->myNum];
>-    I830Ptr pI830 = I830PTR(pScrn);
>     dri_bo *bo = i830_get_pixmap_bo (pixmap);
> 
>     if (bo) {
>@@ -879,10 +872,7 @@ i830_uxa_finish_access (PixmapPtr pixmap)
> 	ScrnInfoPtr scrn = xf86Screens[screen->myNum];
> 	I830Ptr i830 = I830PTR(scrn);
> 
>-	if (pScrn->vtSema && !pI830->use_drm_mode && pI830->memory_manager)
>-	    drm_intel_bo_unpin(bo);
>-	else
>-	    dri_bo_unmap(bo);
>+	//munmap(pixmap->devPrivate.ptr, bo->size);
> 
> 	pixmap->devPrivate.ptr = NULL;
> 	if (bo == i830->front_buffer->bo)

Actions: View | Splinter Review

Attachments on bug 20803: 24144 | 24145 | 24170 | 24172 | 24175 | 24204 | 24219 | 24242 | 24243 | 24280 | 24281 | 24298 | 24299

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.