Attachment 28355 Details for Bug 23126 – 0001-Hack-around-touchpads-with-relative-axes-23126.patch

[patch] 0001-Hack-around-touchpads-with-relative-axes-23126.patch

0001-Hack-around-touchpads-with-relative-axes-23126.patch (text/plain), 1.64 KB, created by Peter Hutterer on 2009-08-04 20:48:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Peter Hutterer

Created: 2009-08-04 20:48:52 UTC

Size: 1.64 KB

patch

obsolete

>From ccd13c567c8edc09b9edf648050bcc4ad8d35389 Mon Sep 17 00:00:00 2001
>From: Peter Hutterer <peter.hutterer@who-t.net>
>Date: Wed, 5 Aug 2009 13:39:34 +1000
>Subject: [PATCH] Hack around touchpads with relative axes (#23126)
>
>Some touchpads (e.g. Alps) have relative axes and absolute ones. Evdev
>doesn't handle devices with both axes, choosing to ignore the absolute ones.
>With the fix to bug 21832, events posted by such touchpads would be dropped.
>
>This patch adds a special hack to ignore relative axes on
>touchpads and set up the absolute axes instead. Other devices are not
>affected.
>
>Approach originally by Michael Witten <mfwitten@gmail.com>
>
>X.Org Bug 23126 <http://bugs.freedesktop.org/show_bug.cgi?id=23126>
>
>Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
>---
> src/evdev.c |   11 +++++++++++
> 1 files changed, 11 insertions(+), 0 deletions(-)
>
>diff --git a/src/evdev.c b/src/evdev.c
>index 9528dbf..4df22f9 100644
>--- a/src/evdev.c
>+++ b/src/evdev.c
>@@ -1437,6 +1437,17 @@ EvdevInit(DeviceIntPtr device)
> 
>         FIXME: somebody volunteer to fix this.
>      */
>+
>+     /* Touchpads always require absolute axes but we post them as relative
>+        ones. This is a hack around this bit of insanity. FIXME: Ideally, we
>+        should also set up the abs axes as relative in the server then
>+        though. */
>+    if (pEvdev->flags & EVDEV_TOUCHPAD) {
>+        xf86Msg(X_INFO,"%s: touchpad found, ignoring relative axes.\n",
>+                device->name);
>+        pEvdev->flags &= ~EVDEV_RELATIVE_EVENTS;
>+    }
>+
>     if (pEvdev->flags & EVDEV_RELATIVE_EVENTS) {
>         if (EvdevAddRelClass(device) == Success)
>         {
>-- 
>1.6.3.rc1.2.g0164.dirty
>

Actions: View | Splinter Review

Attachments on bug 23126: 28329 | 28330 | 28331 | 28334 | 28340 | 28341 | 28355 | 28364 | 28388

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.