Attachment 34718 Details for Bug 27478 – dac adj fix for legacy chips

[patch] dac adj fix for legacy chips

0001-drm-radeon-kms-combios-verify-dac_adj-values-are-va.patch (text/plain), 2.72 KB, created by Alex Deucher on 2010-04-06 09:31:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2010-04-06 09:31:57 UTC

Size: 2.72 KB

patch

obsolete

>From a87e826b3de6d7ab6fadd75feb2076cf595168df Mon Sep 17 00:00:00 2001
>From: Alex Deucher <alexdeucher@gmail.com>
>Date: Tue, 6 Apr 2010 12:27:51 -0400
>Subject: [PATCH] drm/radeon/kms/combios: verify dac_adj values are valid
>
>Some vbios dac_adj tables are all zeros.  Check for that
>case and use the default table if so.
>
>Signed-off-by: Alex Deucher <alexdeucher@gmail.com>
>---
> drivers/gpu/drm/radeon/radeon_combios.c |   20 +++++++++++++++-----
> 1 files changed, 15 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/gpu/drm/radeon/radeon_combios.c b/drivers/gpu/drm/radeon/radeon_combios.c
>index ecef5b4..a80abc4 100644
>--- a/drivers/gpu/drm/radeon/radeon_combios.c
>+++ b/drivers/gpu/drm/radeon/radeon_combios.c
>@@ -760,7 +760,9 @@ struct radeon_encoder_primary_dac *radeon_combios_get_primary_dac_info(struct
> 			dac = RBIOS8(dac_info + 0x3) & 0xf;
> 			p_dac->ps2_pdac_adj = (bg << 8) | (dac);
> 		}
>-		found = 1;
>+		/* if the values are all zeros, use the table */
>+		if (p_dac->ps2_pdac_adj)
>+			found = 1;
> 	}
> 
> 	if (!found) /* fallback to defaults */
>@@ -895,7 +897,9 @@ struct radeon_encoder_tv_dac *radeon_combios_get_tv_dac_info(struct
> 			bg = RBIOS8(dac_info + 0x10) & 0xf;
> 			dac = RBIOS8(dac_info + 0x11) & 0xf;
> 			tv_dac->ntsc_tvdac_adj = (bg << 16) | (dac << 20);
>-			found = 1;
>+			/* if the values are all zeros, use the table */
>+			if (tv_dac->ps2_tvdac_adj)
>+				found = 1;
> 		} else if (rev > 1) {
> 			bg = RBIOS8(dac_info + 0xc) & 0xf;
> 			dac = (RBIOS8(dac_info + 0xc) >> 4) & 0xf;
>@@ -908,7 +912,9 @@ struct radeon_encoder_tv_dac *radeon_combios_get_tv_dac_info(struct
> 			bg = RBIOS8(dac_info + 0xe) & 0xf;
> 			dac = (RBIOS8(dac_info + 0xe) >> 4) & 0xf;
> 			tv_dac->ntsc_tvdac_adj = (bg << 16) | (dac << 20);
>-			found = 1;
>+			/* if the values are all zeros, use the table */
>+			if (tv_dac->ps2_tvdac_adj)
>+				found = 1;
> 		}
> 		tv_dac->tv_std = radeon_combios_get_tv_info(rdev);
> 	}
>@@ -925,7 +931,9 @@ struct radeon_encoder_tv_dac *radeon_combios_get_tv_dac_info(struct
> 				    (bg << 16) | (dac << 20);
> 				tv_dac->pal_tvdac_adj = tv_dac->ps2_tvdac_adj;
> 				tv_dac->ntsc_tvdac_adj = tv_dac->ps2_tvdac_adj;
>-				found = 1;
>+				/* if the values are all zeros, use the table */
>+				if (tv_dac->ps2_tvdac_adj)
>+					found = 1;
> 			} else {
> 				bg = RBIOS8(dac_info + 0x4) & 0xf;
> 				dac = RBIOS8(dac_info + 0x5) & 0xf;
>@@ -933,7 +941,9 @@ struct radeon_encoder_tv_dac *radeon_combios_get_tv_dac_info(struct
> 				    (bg << 16) | (dac << 20);
> 				tv_dac->pal_tvdac_adj = tv_dac->ps2_tvdac_adj;
> 				tv_dac->ntsc_tvdac_adj = tv_dac->ps2_tvdac_adj;
>-				found = 1;
>+				/* if the values are all zeros, use the table */
>+				if (tv_dac->ps2_tvdac_adj)
>+					found = 1;
> 			}
> 		} else {
> 			DRM_INFO("No TV DAC info found in BIOS\n");
>-- 
>1.5.6.3
>

Actions: View | Splinter Review

Attachments on bug 27478: 34695 | 34696 | 34697 | 34714 | 34715 | 34718 | 34734 | 34850 | 35322 | 35360 | 36589 | 36687

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.