Attachment 35191 Details for Bug 26394 – DRI2-drawable-id-check-and -free-resource.patch

[patch] DRI2-drawable-id-check-and -free-resource.patch

DRI2-drawable-id-check-and -free-resource.patch (text/plain), 1.10 KB, created by Li Peng on 2010-04-20 19:09:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Li Peng

Created: 2010-04-20 19:09:46 UTC

Size: 1.10 KB

patch

obsolete

>diff --git a/hw/xfree86/dri2/dri2.c b/hw/xfree86/dri2/dri2.c
>index 6c4dabc..a8a473e 100644
>--- a/hw/xfree86/dri2/dri2.c
>+++ b/hw/xfree86/dri2/dri2.c
>@@ -772,6 +772,12 @@ DRI2HasSwapControl(ScreenPtr pScreen)
>     return (ds->ScheduleSwap && ds->GetMSC);
> }
> 
>+void
>+DRI2DestroyDrawable(DrawablePtr pDraw)
>+{
>+    FreeResourceByType(pDraw->id, dri2DrawableRes, FALSE);
>+}
>+
> Bool
> DRI2Connect(ScreenPtr pScreen, unsigned int driverType, int *fd,
> 	    const char **driverName, const char **deviceName)
>diff --git a/hw/xfree86/dri2/dri2ext.c b/hw/xfree86/dri2/dri2ext.c
>index 17df130..a15df06 100644
>--- a/hw/xfree86/dri2/dri2ext.c
>+++ b/hw/xfree86/dri2/dri2ext.c
>@@ -167,6 +167,9 @@ ProcDRI2CreateDrawable(ClientPtr client)
> 		       &pDrawable, &status))
> 	return status;
> 
>+    if (pDrawable->id == 0)
>+	pDrawable->id = stuff->drawable;
>+
>     status = DRI2CreateDrawable(pDrawable);
>     if (status != Success)
> 	return status;
>@@ -186,6 +189,8 @@ ProcDRI2DestroyDrawable(ClientPtr client)
> 		       &pDrawable, &status))
> 	return status;
> 
>+    DRI2DestroyDrawable(pDrawable);
>+
>     return client->noClientException;
> }
>

Actions: View | Splinter Review

Attachments on bug 26394: 33011 | 34041 | 34244 | 34628 | 34687 | 34730 | 35001 | 35002 | 35003 | 35004 | 35005 | 35006 | 35191 | 35195

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.