Attachment 36234 Details for Bug 26428 – possible fix for bogus cube texture tracking

[patch] possible fix for bogus cube texture tracking

0001-drm-radeon-r200-handle-more-hw-tex-coord-types.patch (text/plain), 1.00 KB, created by Roland Scheidegger on 2010-06-12 07:38:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Roland Scheidegger

Created: 2010-06-12 07:38:57 UTC

Size: 1.00 KB

patch

obsolete

>From a627213ae1d0ae3beb165c37081160dffa95d7a9 Mon Sep 17 00:00:00 2001
>From: Roland Scheidegger <sroland@vmware.com>
>Date: Sat, 12 Jun 2010 16:31:57 +0200
>Subject: [PATCH] drm/radeon/r200: handle more hw tex coord types
>
>Code did not handle projected 2d and depth coordinates, meaning potentially
>set 3d or cube special handling might stick.
>(Not sure what depth coord actually does, but I guess handling it
>like a normal coordinate is the right thing to do.)
>Might be related to https://bugs.freedesktop.org/show_bug.cgi?id=26428
>
>Signed-off-by: sroland@vmware.com
>---
> drivers/gpu/drm/radeon/r200.c |    2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
>diff --git a/drivers/gpu/drm/radeon/r200.c b/drivers/gpu/drm/radeon/r200.c
>index aac4b99..e25d152 100644
>--- a/drivers/gpu/drm/radeon/r200.c
>+++ b/drivers/gpu/drm/radeon/r200.c
>@@ -415,6 +415,8 @@ int r200_packet0_check(struct radeon_cs_parser *p,
> 		/* 2D, 3D, CUBE */
> 		switch (tmp) {
> 		case 0:
>+		case 3:
>+		case 4:
> 		case 5:
> 		case 6:
> 		case 7:
>-- 
>1.5.2.4
>

Actions: View | Splinter Review

Attachments on bug 26428: 33069 | 33070 | 33071 | 33072 | 33082 | 36234 | 36235

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.