Attachment 37794 Details for Bug 29278 – edp mode set fix

[patch] edp mode set fix

0002-drm-i915-eDP-mode-set-sequence-corrections.patch (text/plain), 1.61 KB, created by Jesse Barnes on 2010-08-11 11:16:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jesse Barnes

Created: 2010-08-11 11:16:36 UTC

Size: 1.61 KB

patch

obsolete

>From e428e55b8f8658655630664c07538875d1ad0a43 Mon Sep 17 00:00:00 2001
>From: Jesse Barnes <jbarnes@virtuousgeek.org>
>Date: Wed, 11 Aug 2010 10:06:44 -0700
>Subject: [PATCH 2/2] drm/i915: eDP mode set sequence corrections
>
>We should disable the panel first when shutting down an eDP link.  And
>when turning one on, the panel needs to be enabled before link training
>or eDP I/O won't be enabled.
>
>Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>---
> drivers/gpu/drm/i915/intel_dp.c |   15 ++++++++-------
> 1 files changed, 8 insertions(+), 7 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
>index 048e6a0..cb62c02 100644
>--- a/drivers/gpu/drm/i915/intel_dp.c
>+++ b/drivers/gpu/drm/i915/intel_dp.c
>@@ -809,20 +809,21 @@ intel_dp_dpms(struct drm_encoder *encoder, int mode)
> 	uint32_t dp_reg = I915_READ(dp_priv->output_reg);
> 
> 	if (mode != DRM_MODE_DPMS_ON) {
>+		if (IS_eDP(intel_encoder)) {
>+			ironlake_edp_backlight_off(dev);
>+			ironlake_edp_panel_off(dev);
>+		}
> 		if (dp_reg & DP_PORT_EN) {
> 			intel_dp_link_down(intel_encoder, dp_priv->DP);
>-			if (IS_eDP(intel_encoder)) {
>-				ironlake_edp_backlight_off(dev);
>-				ironlake_edp_panel_off(dev);
>-			}
> 		}
> 	} else {
> 		if (!(dp_reg & DP_PORT_EN)) {
>-			intel_dp_link_train(intel_encoder, dp_priv->DP, dp_priv->link_configuration);
>-			if (IS_eDP(intel_encoder)) {
>+			if (IS_eDP(intel_encoder))
> 				ironlake_edp_panel_on(dev);
>+			intel_dp_link_train(intel_encoder, dp_priv->DP,
>+					    dp_priv->link_configuration);
>+			if (IS_eDP(intel_encoder))
> 				ironlake_edp_backlight_on(dev);
>-			}
> 		}
> 	}
> 	dp_priv->dpms_mode = mode;
>-- 
>1.7.0.4
>

Actions: View | Splinter Review

Attachments on bug 29278: 37419 | 37420 | 37794 | 37795 | 38110 | 38127 | 38527 | 38538 | 38750 | 38805 | 38810 | 38828 | 38868 | 38987 | 39104 | 39293 | 39835 | 39836 | 39970 | 39971 | 40116 | 40505 | 40515 | 40516 | 40517 | 40518 | 40543 | 41121 | 41675 | 41830 | 43401

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.