Attachment 55753 Details for Bug 44913 – [PATCH] build: Add --disable-fatal-warnings

[patch] [PATCH] build: Add --disable-fatal-warnings

gstreamer-warning-errors.patch (text/plain), 1.89 KB, created by Colin Walters on 2012-01-18 13:05:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Colin Walters

Created: 2012-01-18 13:05:13 UTC

Size: 1.89 KB

patch

obsolete

>From 40ff38e54022d5330499addb8f9c4053bcccf413 Mon Sep 17 00:00:00 2001
>From: Colin Walters <walters@verbum.org>
>Date: Tue, 17 Jan 2012 16:23:33 -0500
>Subject: [PATCH] build: Add --disable-fatal-warnings
>
>It's reasonable to build from git, but not want to turn all compiler
>warnings into fatal errors.  For example, GNOME's jhbuild helps people
>get newer versions of software than came from their distribution, but
>they may not necessarily want to hack on it.
>---
> configure.ac |    8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/configure.ac b/configure.ac
>index 7a4d052..d02b043 100644
>--- a/configure.ac
>+++ b/configure.ac
>@@ -16,6 +16,10 @@ AS_VERSION
> 
> dnl check if this is a release version
> AS_NANO(GST_GIT="no", GST_GIT="yes")
>+AC_ARG_ENABLE(fatal-warnings,
>+  AS_HELP_STRING([--enable-fatal-warnings],
>+		 [Turn compiler warnings into fatal errors]),
>+  [GST_FATAL_WARNINGS=$enableval], [GST_FATAL_WARNINGS=$GST_GIT])
> 
> dnl can autoconf find the source ?
> AC_CONFIG_SRCDIR([gst/gst.c])
>@@ -646,10 +650,10 @@ if test "x${GST_DISABLE_GST_DEBUG}" = "xyes"; then
> fi
> 
> dnl define an ERROR_CFLAGS Makefile variable
>-AG_GST_SET_ERROR_CFLAGS($GST_GIT, [-Wmissing-declarations -Wmissing-prototypes -Wredundant-decls -Wundef -Wwrite-strings -Wformat-nonliteral -Wformat-security -Wold-style-definition -Winit-self -Wmissing-include-dirs -Waddress -Waggregate-return -Wno-multichar -Wnested-externs $NO_WARNINGS])
>+AG_GST_SET_ERROR_CFLAGS($GST_FATAL_WARNINGS, [-Wmissing-declarations -Wmissing-prototypes -Wredundant-decls -Wundef -Wwrite-strings -Wformat-nonliteral -Wformat-security -Wold-style-definition -Winit-self -Wmissing-include-dirs -Waddress -Waggregate-return -Wno-multichar -Wnested-externs $NO_WARNINGS])
> 
> dnl define correct level for debugging messages
>-AG_GST_SET_LEVEL_DEFAULT($GST_GIT)
>+AG_GST_SET_LEVEL_DEFAULT($GST_FATAL_WARNINGS)
> 
> dnl *** finalize CFLAGS, LDFLAGS, LIBS
> 
>-- 
>1.7.6.5
>

Actions: View | Splinter Review

Attachments on bug 44913: 55753

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.