Attachment 59697 Details for Bug 48478 – lib: Add missing return in libaccountsservice

[patch] lib: Add missing return in libaccountsservice

0001-lib-Add-missing-return-in-libaccountsservice.txt (text/plain), 1.57 KB, created by Alban Browaeys on 2012-04-09 13:50:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alban Browaeys

Created: 2012-04-09 13:50:11 UTC

Size: 1.57 KB

patch

obsolete

>From b1c0678eae101589dfe8732cb9a4e8de1cef7ca6 Mon Sep 17 00:00:00 2001
>From: Alban Browaeys <prahal@yahoo.com>
>Date: Mon, 9 Apr 2012 22:36:29 +0200
>Subject: [PATCH] lib: Add missing return in libaccountsservice
>
>In _get_x11_display_for_new_systemd_session there is a missing return.
>
>I found out that running gnome-shell from a remote box via ssh and
>setting DISPLAY to :0 the systemd session type is tty. Also the uid
>systemd is 0 for my user jhbuild gnome session run from debian gdm3
>(ie not based on gnome-shell).
>This triggers this error path which miss a "return" instruction.
>
>I have been unable to find out if session type and uid are the same
>for the same gdm session with gnome-shell started from gnome-session
>though at least it also fixes the segfault there too.
>
>This error code path is not triggered when starting gnome-session with
>gnome-shell from a console + xinit inside a "jhbuild shell".
>So this might be a weird use case but good to fix nevertheless.
>---
> src/libaccountsservice/act-user-manager.c |    1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/src/libaccountsservice/act-user-manager.c b/src/libaccountsservice/act-user-manager.c
>index d1971dd..68b8670 100644
>--- a/src/libaccountsservice/act-user-manager.c
>+++ b/src/libaccountsservice/act-user-manager.c
>@@ -1264,6 +1264,7 @@ _get_x11_display_for_new_systemd_session (ActUserManagerNewSession *new_session)
>                          strerror (-res));
>                 free (session_type);
>                 unload_new_session (new_session);
>+                return;
>         }
>         free (session_type);
> 
>-- 
>1.7.9.5
>

Actions: View | Splinter Review

Attachments on bug 48478: 59697

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.