Attachment 61028 Details for Bug 49384 – [master, 2/7] Mark all -internal headers as /*<private_header>*/

[patch] [master, 2/7] Mark all -internal headers as /*<private_header>*/

0002-Mark-all-internal-headers-as-private_header.patch (text/plain), 15.62 KB, created by Simon McVittie on 2012-05-04 07:04:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2012-05-04 07:04:24 UTC

Size: 15.62 KB

patch

obsolete

>From 7555252c465c238babb787b4fbd4a1e83ad01301 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Fri, 4 May 2012 12:48:50 +0100
>Subject: [PATCH 2/7] Mark all -internal headers as /*<private_header>*/
>
>This is a nicer way to get them out of the gtk-doc than listing them all
>in docs/reference/Makefile.am. (We still need to mention
>proxy-introspectable.h there, though - it's private from gtk-doc's
>point of view, but not gobject-introspection's.)
>---
> docs/reference/Makefile.am                         |   27 +-------------------
> telepathy-glib/account-channel-request-internal.h  |    1 +
> telepathy-glib/account-internal.h                  |    1 +
> telepathy-glib/account-manager-internal.h          |    1 +
> .../add-dispatch-operation-context-internal.h      |    1 +
> telepathy-glib/automatic-client-factory-internal.h |    1 +
> telepathy-glib/base-call-internal.h                |    1 +
> telepathy-glib/base-client-internal.h              |    1 +
> telepathy-glib/base-connection-internal.h          |    1 +
> telepathy-glib/base-contact-list-internal.h        |    1 +
> telepathy-glib/base-protocol-internal.h            |    1 +
> telepathy-glib/call-internal.h                     |    1 +
> telepathy-glib/capabilities-internal.h             |    1 +
> .../channel-dispatch-operation-internal.h          |    1 +
> telepathy-glib/channel-internal.h                  |    1 +
> telepathy-glib/client-message-internal.h           |    1 +
> telepathy-glib/cm-message-internal.h               |    1 +
> telepathy-glib/connection-internal.h               |    1 +
> telepathy-glib/contact-internal.h                  |    1 +
> telepathy-glib/contact-list-channel-internal.h     |    1 +
> telepathy-glib/contact-search-internal.h           |    1 +
> telepathy-glib/dbus-internal.h                     |    1 +
> telepathy-glib/debug-internal.h                    |    2 ++
> telepathy-glib/debug-message-internal.h            |    1 +
> telepathy-glib/deprecated-internal.h               |    1 +
> telepathy-glib/handle-channels-context-internal.h  |    1 +
> telepathy-glib/handle-repo-internal.h              |    1 +
> telepathy-glib/message-internal.h                  |    1 +
> telepathy-glib/observe-channels-context-internal.h |    1 +
> telepathy-glib/protocol-internal.h                 |    1 +
> telepathy-glib/proxy-internal.h                    |    1 +
> telepathy-glib/room-info-internal.h                |    1 +
> telepathy-glib/signalled-message-internal.h        |    1 +
> telepathy-glib/simple-client-factory-internal.h    |    1 +
> telepathy-glib/stream-tube-connection-internal.h   |    1 +
> telepathy-glib/util-internal.h                     |    1 +
> 36 files changed, 37 insertions(+), 26 deletions(-)
>
>diff --git a/docs/reference/Makefile.am b/docs/reference/Makefile.am
>index fbdee20..9823596 100644
>--- a/docs/reference/Makefile.am
>+++ b/docs/reference/Makefile.am
>@@ -62,33 +62,8 @@ EXTRA_HFILES=
> # Header files or dirs to ignore when scanning. Use base file/dir names
> # e.g. IGNORE_HFILES=gtkdebug.h gtkintl.h private_code
> IGNORE_HFILES=\
>-    account-channel-request-internal.h \
>-    add-dispatch-operation-context-internal.h \
>-    automatic-client-factory-internal.h \
>-    base-call-internal.h \
>-    base-connection-internal.h \
>-    base-contact-list-internal.h \
>-    base-protocol-internal.h \
>-    call-internal.h \
>-    channel-dispatch-operation-internal.h \
>-    channel-internal.h \
>-    client-message-internal.h \
>-    cm-message-internal.h \
>-    connection-internal.h \
>-    contact-internal.h \
>-    contact-list-channel-internal.h \
>-    debug-internal.h \
>-    deprecated-internal.h \
>-    handle-channels-context-internal.h \
>-    handle-repo-internal.h \
>-    message-internal.h \
>-    observe-channels-context-internal.h \
>-    protocol-internal.h \
>-    proxy-internal.h \
>     proxy-introspectable.h \
>-    signalled-message-internal.h \
>-    simple-client-factory-internal.h \
>-    util-internal.h
>+    $(NULL)
> 
> # Images to copy into HTML directory.
> # e.g. HTML_IMAGES=$(top_srcdir)/gtk/stock-icons/stock_about_24.png
>diff --git a/telepathy-glib/account-channel-request-internal.h b/telepathy-glib/account-channel-request-internal.h
>index 03f7033..644064f 100644
>--- a/telepathy-glib/account-channel-request-internal.h
>+++ b/telepathy-glib/account-channel-request-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /*
>  * object used to request a channel from a TpAccount (internal)
>  *
>diff --git a/telepathy-glib/account-internal.h b/telepathy-glib/account-internal.h
>index 2fbf071..93eb2a3 100644
>--- a/telepathy-glib/account-internal.h
>+++ b/telepathy-glib/account-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /*
>  * TpAccount - proxy for a Telepathy account (internals)
>  *
>diff --git a/telepathy-glib/account-manager-internal.h b/telepathy-glib/account-manager-internal.h
>index 4ac35c5..c05ef4a 100644
>--- a/telepathy-glib/account-manager-internal.h
>+++ b/telepathy-glib/account-manager-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /*
>  * TpAccountManager - proxy for a Telepathy account manager (internals)
>  *
>diff --git a/telepathy-glib/add-dispatch-operation-context-internal.h b/telepathy-glib/add-dispatch-operation-context-internal.h
>index c07740f..0c56304 100644
>--- a/telepathy-glib/add-dispatch-operation-context-internal.h
>+++ b/telepathy-glib/add-dispatch-operation-context-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /*
>  * Context objects for AddDispatchOperation calls (internal)
>  *
>diff --git a/telepathy-glib/automatic-client-factory-internal.h b/telepathy-glib/automatic-client-factory-internal.h
>index f69319b..4468230 100644
>--- a/telepathy-glib/automatic-client-factory-internal.h
>+++ b/telepathy-glib/automatic-client-factory-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /*
>  * Internal constructors for TpChannel subclasses
>  *
>diff --git a/telepathy-glib/base-call-internal.h b/telepathy-glib/base-call-internal.h
>index 3fbbeac..1f32a6b 100644
>--- a/telepathy-glib/base-call-internal.h
>+++ b/telepathy-glib/base-call-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /*
>  * base-call-internal.h - Header for TpBaseCall* (internals)
>  * Copyright Â© 2011 Collabora Ltd.
>diff --git a/telepathy-glib/base-client-internal.h b/telepathy-glib/base-client-internal.h
>index 776e3a7..4707049 100644
>--- a/telepathy-glib/base-client-internal.h
>+++ b/telepathy-glib/base-client-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /*
>  * Base class for Client implementations
>  *
>diff --git a/telepathy-glib/base-connection-internal.h b/telepathy-glib/base-connection-internal.h
>index 5cc8804..cd731d4 100644
>--- a/telepathy-glib/base-connection-internal.h
>+++ b/telepathy-glib/base-connection-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /* Base class for Connection implementations
>  *
>  * Copyright Â© 2007-2010 Collabora Ltd.
>diff --git a/telepathy-glib/base-contact-list-internal.h b/telepathy-glib/base-contact-list-internal.h
>index b432103..5258ab4 100644
>--- a/telepathy-glib/base-contact-list-internal.h
>+++ b/telepathy-glib/base-contact-list-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /* ContactList channel manager - internals (for use by our channels)
>  *
>  * Copyright Â© 2010 Collabora Ltd.
>diff --git a/telepathy-glib/base-protocol-internal.h b/telepathy-glib/base-protocol-internal.h
>index 555f502..498debb 100644
>--- a/telepathy-glib/base-protocol-internal.h
>+++ b/telepathy-glib/base-protocol-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /* TpBaseProtocol (not public API)
>  *
>  * Copyright Â© 2007-2010 Collabora Ltd.
>diff --git a/telepathy-glib/call-internal.h b/telepathy-glib/call-internal.h
>index 4d0952e..e098674 100644
>--- a/telepathy-glib/call-internal.h
>+++ b/telepathy-glib/call-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /*
>  * Internals for TpCallChannel, TpCallContent and TpCallStream
>  *
>diff --git a/telepathy-glib/capabilities-internal.h b/telepathy-glib/capabilities-internal.h
>index 08609e5..10dd0fe 100644
>--- a/telepathy-glib/capabilities-internal.h
>+++ b/telepathy-glib/capabilities-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /* Object representing the capabilities a Connection or a Contact
>  * supports (internals).
>  *
>diff --git a/telepathy-glib/channel-dispatch-operation-internal.h b/telepathy-glib/channel-dispatch-operation-internal.h
>index 9db1607..f04b7fb 100644
>--- a/telepathy-glib/channel-dispatch-operation-internal.h
>+++ b/telepathy-glib/channel-dispatch-operation-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /*
>  * channel-dispatch-operation-internal.h - proxy for channels awaiting approval
>  *
>diff --git a/telepathy-glib/channel-internal.h b/telepathy-glib/channel-internal.h
>index f8700f2..17d6f88 100644
>--- a/telepathy-glib/channel-internal.h
>+++ b/telepathy-glib/channel-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /*
>  * TpChannel - proxy for a Telepathy channel (internals)
>  *
>diff --git a/telepathy-glib/client-message-internal.h b/telepathy-glib/client-message-internal.h
>index a0753fa..c4482c5 100644
>--- a/telepathy-glib/client-message-internal.h
>+++ b/telepathy-glib/client-message-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /*
>  * client-message-internal.h - Header for TpClientMessage (internal)
>  * Copyright (C) 2006-2010 Collabora Ltd.
>diff --git a/telepathy-glib/cm-message-internal.h b/telepathy-glib/cm-message-internal.h
>index d626862..3442145 100644
>--- a/telepathy-glib/cm-message-internal.h
>+++ b/telepathy-glib/cm-message-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /*
>  * message-internal.h - Header for TpCMMessage (internal
>  * Copyright (C) 2006-2010 Collabora Ltd.
>diff --git a/telepathy-glib/connection-internal.h b/telepathy-glib/connection-internal.h
>index 54572cc..a6d6221 100644
>--- a/telepathy-glib/connection-internal.h
>+++ b/telepathy-glib/connection-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /*
>  * TpConnection - proxy for a Telepathy connection (internals)
>  *
>diff --git a/telepathy-glib/contact-internal.h b/telepathy-glib/contact-internal.h
>index fde16cd..5bc1696 100644
>--- a/telepathy-glib/contact-internal.h
>+++ b/telepathy-glib/contact-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /* Object representing a Telepathy contact (internal)
>  *
>  * Copyright Â© 2011 Collabora Ltd. <http://www.collabora.co.uk/>
>diff --git a/telepathy-glib/contact-list-channel-internal.h b/telepathy-glib/contact-list-channel-internal.h
>index 21acb63..a1f1fa1 100644
>--- a/telepathy-glib/contact-list-channel-internal.h
>+++ b/telepathy-glib/contact-list-channel-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /* A ContactList channel with handle type LIST or GROUP.
>  *
>  * Copyright Â© 2009-2010 Collabora Ltd. <http://www.collabora.co.uk/>
>diff --git a/telepathy-glib/contact-search-internal.h b/telepathy-glib/contact-search-internal.h
>index a5d6766..d549900 100644
>--- a/telepathy-glib/contact-search-internal.h
>+++ b/telepathy-glib/contact-search-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /*
>  * contact-search-internal.h - private functions for contact searches
>  *
>diff --git a/telepathy-glib/dbus-internal.h b/telepathy-glib/dbus-internal.h
>index 1c34728..50259a5 100644
>--- a/telepathy-glib/dbus-internal.h
>+++ b/telepathy-glib/dbus-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /*
>  * internal-dbus-glib.h - private header for dbus-glib glue
>  *
>diff --git a/telepathy-glib/debug-internal.h b/telepathy-glib/debug-internal.h
>index 9ceb912..cea13da 100644
>--- a/telepathy-glib/debug-internal.h
>+++ b/telepathy-glib/debug-internal.h
>@@ -1,3 +1,5 @@
>+/*<private_header>*/
>+
> #ifndef __DEBUG_H__
> #define __DEBUG_H__
> 
>diff --git a/telepathy-glib/debug-message-internal.h b/telepathy-glib/debug-message-internal.h
>index 56039d7..df00510 100644
>--- a/telepathy-glib/debug-message-internal.h
>+++ b/telepathy-glib/debug-message-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /*
>  * debug-message-internal.h
>  *
>diff --git a/telepathy-glib/deprecated-internal.h b/telepathy-glib/deprecated-internal.h
>index e17b9df..995e3e8 100644
>--- a/telepathy-glib/deprecated-internal.h
>+++ b/telepathy-glib/deprecated-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /* Deprecated functions still used internally
>  *
>  * Copyright (C) 2011 Collabora Ltd. <http://www.collabora.co.uk/>
>diff --git a/telepathy-glib/handle-channels-context-internal.h b/telepathy-glib/handle-channels-context-internal.h
>index f440c4e..ac0e85a 100644
>--- a/telepathy-glib/handle-channels-context-internal.h
>+++ b/telepathy-glib/handle-channels-context-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /*
>  * object for HandleChannels calls context (internal)
>  *
>diff --git a/telepathy-glib/handle-repo-internal.h b/telepathy-glib/handle-repo-internal.h
>index 200bb83..722f59c 100644
>--- a/telepathy-glib/handle-repo-internal.h
>+++ b/telepathy-glib/handle-repo-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /*
>  * internal-handle-repo.h - private header for handle repositories
>  *
>diff --git a/telepathy-glib/message-internal.h b/telepathy-glib/message-internal.h
>index b62cb3b..69ae311 100644
>--- a/telepathy-glib/message-internal.h
>+++ b/telepathy-glib/message-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /*
>  * message-internal.h - Header for TpMessage (internal
>  * Copyright (C) 2006-2010 Collabora Ltd.
>diff --git a/telepathy-glib/observe-channels-context-internal.h b/telepathy-glib/observe-channels-context-internal.h
>index 992724f..de496f1 100644
>--- a/telepathy-glib/observe-channels-context-internal.h
>+++ b/telepathy-glib/observe-channels-context-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /*
>  * Context objects for TpBaseClient calls (internal)
>  *
>diff --git a/telepathy-glib/protocol-internal.h b/telepathy-glib/protocol-internal.h
>index a1e7aaf..d53c61f 100644
>--- a/telepathy-glib/protocol-internal.h
>+++ b/telepathy-glib/protocol-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /* TpProtocol - internal header
>  *
>  * Copyright Â© 2010 Collabora Ltd.
>diff --git a/telepathy-glib/proxy-internal.h b/telepathy-glib/proxy-internal.h
>index 0440036..b53a82c 100644
>--- a/telepathy-glib/proxy-internal.h
>+++ b/telepathy-glib/proxy-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /*
>  * Copyright (C) 2007-2008 Collabora Ltd. <http://www.collabora.co.uk/>
>  * Copyright (C) 2007-2008 Nokia Corporation
>diff --git a/telepathy-glib/room-info-internal.h b/telepathy-glib/room-info-internal.h
>index 454e0e0..00cc1f7 100644
>--- a/telepathy-glib/room-info-internal.h
>+++ b/telepathy-glib/room-info-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /*
>  * room-info-internal.h
>  *
>diff --git a/telepathy-glib/signalled-message-internal.h b/telepathy-glib/signalled-message-internal.h
>index 090f4d5..0063ad9 100644
>--- a/telepathy-glib/signalled-message-internal.h
>+++ b/telepathy-glib/signalled-message-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /*
>  * signalled-message-internal.h - Header for TpSignalledMessage (internal)
>  * Copyright (C) 2006-2010 Collabora Ltd.
>diff --git a/telepathy-glib/simple-client-factory-internal.h b/telepathy-glib/simple-client-factory-internal.h
>index 61f81d8..495052f 100644
>--- a/telepathy-glib/simple-client-factory-internal.h
>+++ b/telepathy-glib/simple-client-factory-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /*
>  * Internal methods of TpSimpleClientFactory
>  *
>diff --git a/telepathy-glib/stream-tube-connection-internal.h b/telepathy-glib/stream-tube-connection-internal.h
>index 64c42a5..6ef6b62 100644
>--- a/telepathy-glib/stream-tube-connection-internal.h
>+++ b/telepathy-glib/stream-tube-connection-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /*
>  * Object representing a connection on a Stream Tube (internal)
>  *
>diff --git a/telepathy-glib/util-internal.h b/telepathy-glib/util-internal.h
>index d85110b..d035270 100644
>--- a/telepathy-glib/util-internal.h
>+++ b/telepathy-glib/util-internal.h
>@@ -1,3 +1,4 @@
>+/*<private_header>*/
> /*
>  * util-internal.h - Headers for non-public telepathy-glib utility functions
>  *
>-- 
>1.7.10
>

Actions: View | Splinter Review

Attachments on bug 49384: 61027 | 61028 | 61030 | 61031 | 61032 | 61033 | 61034 | 61035 | 61036 | 62274 | 62275 | 62276 | 62277 | 62278 | 62279 | 62280 | 62525 | 62526 | 62527 | 62528 | 62529 | 62530 | 62531

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.