Attachment 61173 Details for Bug 49600 – 5/8] Update Renaming interface from spec 0.25.2 to satisfy pickier codegen

[patch] 5/8] Update Renaming interface from spec 0.25.2 to satisfy pickier codegen

0005-Update-Renaming-interface-from-spec-0.25.2-to-satisf.patch (text/plain), 3.98 KB, created by Simon McVittie on 2012-05-07 12:09:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2012-05-07 12:09:46 UTC

Size: 3.98 KB

patch

obsolete

>From 0a086022e73292c2764d1c88058340aae88c4b94 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Mon, 7 May 2012 19:59:47 +0100
>Subject: [PATCH 5/8] Update Renaming interface from spec 0.25.2 to satisfy
> pickier codegen
>
>---
> extensions/Connection_Interface_Renaming.xml | 27 +++++++++++++++-----------
> 1 file changed, 16 insertions(+), 11 deletions(-)
>
>diff --git a/extensions/Connection_Interface_Renaming.xml b/extensions/Connection_Interface_Renaming.xml
>index 7d94451..d08b748 100644
>--- a/extensions/Connection_Interface_Renaming.xml
>+++ b/extensions/Connection_Interface_Renaming.xml
>@@ -12,21 +12,22 @@ version 2.1 of the License, or (at your option) any later version.
> This library is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
>-Library General Public License for more details.
>+Lesser General Public License for more details.
> 
> You should have received a copy of the GNU Lesser General Public
> License along with this library; if not, write to the Free Software
> Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
> </tp:license>
>- <interface name="org.freedesktop.Telepathy.Connection.Interface.Renaming">
>+ <interface name="org.freedesktop.Telepathy.Connection.Interface.Renaming"
>+ tp:causes-havoc='not well-tested'>
> <tp:requires interface="org.freedesktop.Telepathy.Connection"/>
>- <signal name="Renamed">
>- <arg name="original" type="u" tp:type="Contact_Handle">
>+ <signal name="Renamed" tp:name-for-bindings="Renamed">
>+ <arg name="Original" type="u" tp:type="Contact_Handle">
> <tp:docstring>
> The handle of the original identifier
> </tp:docstring>
> </arg>
>- <arg name="new" type="u" tp:type="Contact_Handle">
>+ <arg name="New" type="u" tp:type="Contact_Handle">
> <tp:docstring>
> The handle of the new identifier
> </tp:docstring>
>@@ -49,8 +50,11 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.</
> If the contact's old handle is in any of the member lists of
> a channel which has the groups interface, it will be removed from
> the channel and the new handle will be added. The resulting
>- MembersChanged signal must be emitted after the Renamed
>- signal; the reason should be RENAMED.
>+ <tp:dbus-ref
>+ namespace="org.freedesktop.Telepathy.Channel.Interface.Group">MembersChanged</tp:dbus-ref>
>+ signal must be emitted after the
>+ <tp:member-ref>Renamed</tp:member-ref> signal; the reason should be
>+ RENAMED.
> 
> 
> The handles may be either general-purpose or channel-specific.
>@@ -60,16 +64,17 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.</
> 
> </tp:docstring>
> </signal>
>- <method name="RequestRename">
>- <arg direction="in" name="name" type="s">
>+ <method name="RequestRename" tp:name-for-bindings="Request_Rename">
>+ <arg direction="in" name="Identifier" type="s">
> <tp:docstring>
> The desired identifier
> </tp:docstring>
> </arg>
> <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
> Request that the user's own identifier is changed on the server.
>- If successful, a Renamed signal will be emitted for the current
>- "self handle" as returned by GetSelfHandle.
>+ If successful, a <tp:member-ref>Renamed</tp:member-ref> signal will
>+ be emitted for the current "self handle" as returned by <tp:dbus-ref
>+ namespace="org.freedesktop.Telepathy.Connection">GetSelfHandle</tp:dbus-ref>.
> It is protocol-dependent how the identifier that's actually
> used will be derived from the supplied identifier; some sort of
> normalization might take place.
>-- 
>1.7.10
>

Actions: View | Splinter Review

Attachments on bug 49600: 61169 | 61170 | 61171 | 61172 | 61173 | 61174 | 61175 | 61176

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.